From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET
Date: Fri, 16 Dec 2011 17:07:51 -0500 [thread overview]
Message-ID: <201112161707.52335.vapier@gentoo.org> (raw)
In-Reply-To: <13CD0328-096C-4B91-BE44-482362952257@boeing.com>
On Friday 16 December 2011 15:42:26 Moffett, Kyle D wrote:
> On Dec 16, 2011, at 14:30, Mike Frysinger wrote:
> > On Friday 16 December 2011 13:49:15 Moffett, Kyle D wrote:
> >> On Dec 16, 2011, at 00:05, Mike Frysinger wrote:
> >>> On Thursday 15 December 2011 22:32:41 Kyle Moffett wrote:
> >>>> This new #define is set in config_cmd_defaults.h (which is
> >>>> automatically included on every board by "mkconfig"), but this allows
> >>>> boards to elect to omit the "reset" command if necessary with "#undef
> >>>> CONFIG_CMD_RESET".
> >>>
> >>> would be a good time to split this into a dedicated common/cmd_reset.c,
> >>> we can also then fix cmd_boot.c to only build when CONFIG_CMD_GO is
> >>> enabled
> >>
> >> The only references to CONFIG_CMD_GO are in config_cmd_defaults.h,
> >> README, and common/cmd_boot.c, there is nothing that ever turns it off,
> >> so perhaps the config symbol should just be removed?
> >
> > i have some boards that turn it off
>
> Ok,
>
> I really don't see the point in moving these 5 lines to their own file,
> especially since they are in is already just 78 lines long:
> U_BOOT_CMD(
> reset, 1, 0, do_reset,
> "Perform RESET of the CPU",
> ""
> );
>
> If you really think that's what I should do, though, I'll go ahead and
> make that change.
i think so, that way we can change cmd_boot.o in the Makefile to depend on
CONFIG_CMD_GO and drop the ifdef logic from cmd_boot.c
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111216/cda1c106/attachment.pgp>
next prev parent reply other threads:[~2011-12-16 22:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 3:32 [U-Boot] [PATCH] Allow the "reset" command to be omitted with CONFIG_CMD_RESET Kyle Moffett
2011-12-16 5:05 ` Mike Frysinger
2011-12-16 18:49 ` Moffett, Kyle D
2011-12-16 19:30 ` Mike Frysinger
2011-12-16 20:42 ` Moffett, Kyle D
2011-12-16 22:07 ` Mike Frysinger [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-20 19:05 Kyle Moffett
2011-10-20 19:53 ` Mike Frysinger
2011-10-20 20:10 ` Moffett, Kyle D
2011-10-20 20:22 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112161707.52335.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox