From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Fri, 16 Dec 2011 18:49:35 -0500 Subject: [U-Boot] [PATCH] add missing space In-Reply-To: <20111216234317.GB1393@w500.iskon.local> References: <20111215233215.GB21725@w500.lan> <201112161059.05231.vapier@gentoo.org> <20111216234317.GB1393@w500.iskon.local> Message-ID: <201112161849.36707.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 16 December 2011 18:43:18 Luka Perkov wrote: > On Fri, Dec 16, 2011 at 10:59:03AM -0500, Mike Frysinger wrote: > > On Friday 16 December 2011 07:13:47 Anatolij Gustschin wrote: > > > On Fri, 16 Dec 2011 00:32:15 +0100 Luka Perkov wrote: > > > > Cosmetic patch for first U-Boot line that gets printed. > > > > > > > > --- a/include/version.h > > > > +++ b/include/version.h > > > > > > > > #define U_BOOT_VERSION_STRING U_BOOT_VERSION " (" U_BOOT_DATE " - " > > > > \ > > > > > > > > - U_BOOT_TIME ")" CONFIG_IDENT_STRING > > > > + U_BOOT_TIME ") " CONFIG_IDENT_STRING > > > > > > This change is not needed I think. Most boards defining > > > CONFIG_IDENT_STRING use either a string starting with new line or > > > strings like " something". So this patch will deface version string. > > > Your CONFIG_IDENT_STRING should be fixed instead. > > > > +1 > > -mike > > Ok, thanks for pointing this out. I guess that something like patch > bellow is not acceptable? no, because you're adding a useless space for everyone who doesn't define CONFIG_IDENT_STRING :) -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: