From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 16 Dec 2011 21:36:37 +0100 Subject: [U-Boot] [PATCH 1/2] NET: NE2000: Cleanup IO accessors In-Reply-To: <201112161432.54362.vapier@gentoo.org> References: <1323565772-4498-1-git-send-email-marek.vasut@gmail.com> <201112161913.33530.marek.vasut@gmail.com> <201112161432.54362.vapier@gentoo.org> Message-ID: <201112162136.38003.marek.vasut@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de > On Friday 16 December 2011 13:13:33 Marek Vasut wrote: > > On Friday 16 December 2011 12:33:53 Mike Frysinger wrote: > > > rename ISA_OFFSET to CONFIG_NE2000_IO_OFFSET, then move the "2" to > > > CONFIG_NE2000_IO_STRIDE, and move them both to the board config header. > > > then you get one unified set: > > > > > > #define DP_IN(_b_, _o_, _d_) \ > > > > > > (_d_) = readw((void *)((_b_) + ((_o_) * CONFIG_NE2000_IO_STRIDE) + \ > > > > > > CONFIG_NE2000_IO_OFFSET)); > > > > > > etc... > > > > > > if you really wanted to clean up the driver, the DP_XXX funcs would get > > > turned into C code as static inline helpers, and the base + register > > > offset would get turned into a C struct. > > > > Ok, so if you had two different piece of hardware that had different > > NE2000_IO_OFFSET and STRIDE, running the same u-boot, how'd you handle it > > ? > > do you actually have this issue ? there are plenty of theoretical > situations like this which would break a significant number (majority?) of > drivers in the tree. so unless this is a real case, i'd ignore it for now > and stick with what optimizes away to no overhead. Sadly, I almost do. Not now of course, but eventually, I'll be there :-( M