public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask
@ 2011-12-17 17:28 Michael Walle
  2011-12-17 17:31 ` Michael Walle
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Walle @ 2011-12-17 17:28 UTC (permalink / raw)
  To: u-boot

Since the data alignment fault was enabled recently in commit
  arm, arm926ejs: always do cpu critical inits
the driver won't work anymore and all boards which use an environment in an
SPI flash will fail booting.

Signed-off-by: Michael Walle <michael@walle.cc>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
 drivers/spi/kirkwood_spi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/kirkwood_spi.c b/drivers/spi/kirkwood_spi.c
index a50e498..9aaecfe 100644
--- a/drivers/spi/kirkwood_spi.c
+++ b/drivers/spi/kirkwood_spi.c
@@ -67,7 +67,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
 	debug("data = 0x%08x \n", data);
 
 	writel(KWSPI_SMEMRDIRQ, &spireg->irq_cause);
-	writel(KWSPI_IRQMASK, spireg->irq_mask);
+	writel(KWSPI_IRQMASK, &spireg->irq_mask);
 
 	/* program mpp registers to select  SPI_CSn */
 	if (cs) {
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask
  2011-12-17 17:28 [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask Michael Walle
@ 2011-12-17 17:31 ` Michael Walle
  2011-12-18  1:57   ` Prafulla Wadaskar
  0 siblings, 1 reply; 4+ messages in thread
From: Michael Walle @ 2011-12-17 17:31 UTC (permalink / raw)
  To: u-boot

Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
> Since the data alignment fault was enabled recently in commit
>   arm, arm926ejs: always do cpu critical inits
> the driver won't work anymore and all boards which use an environment in an
> SPI flash will fail booting.

Sorry i don't know how you track patches that should be applied for the RC. 
But IMHO this is one :)

-- 
Michael

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask
  2011-12-17 17:31 ` Michael Walle
@ 2011-12-18  1:57   ` Prafulla Wadaskar
  2012-01-02 18:38     ` Michael Walle
  0 siblings, 1 reply; 4+ messages in thread
From: Prafulla Wadaskar @ 2011-12-18  1:57 UTC (permalink / raw)
  To: u-boot



> -----Original Message-----
> From: Michael Walle [mailto:michael at walle.cc]
> Sent: 17 December 2011 09:31
> To: u-boot at lists.denx.de
> Cc: Albert ARIBAUD; Prafulla Wadaskar; Wolfgang Denk
> Subject: Re: [PATCH] kirkwood_spi: fix setting of irq mask
> 
> Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
> > Since the data alignment fault was enabled recently in commit
> >   arm, arm926ejs: always do cpu critical inits
> > the driver won't work anymore and all boards which use an
> environment in an
> > SPI flash will fail booting.
> 
> Sorry i don't know how you track patches that should be applied for
> the RC.
> But IMHO this is one :)

Thanks Michael
I will take care of that.

Regards..
Prafulla . . .

> 
> --
> Michael

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask
  2011-12-18  1:57   ` Prafulla Wadaskar
@ 2012-01-02 18:38     ` Michael Walle
  0 siblings, 0 replies; 4+ messages in thread
From: Michael Walle @ 2012-01-02 18:38 UTC (permalink / raw)
  To: u-boot

Am Sonntag 18 Dezember 2011, 02:57:01 schrieb Prafulla Wadaskar:
> > -----Original Message-----
> > From: Michael Walle [mailto:michael at walle.cc]
> > Sent: 17 December 2011 09:31
> > To: u-boot at lists.denx.de
> > Cc: Albert ARIBAUD; Prafulla Wadaskar; Wolfgang Denk
> > Subject: Re: [PATCH] kirkwood_spi: fix setting of irq mask
> > 
> > Am Samstag 17 Dezember 2011, 18:28:05 schrieb Michael Walle:
> > > Since the data alignment fault was enabled recently in commit
> > > 
> > >   arm, arm926ejs: always do cpu critical inits
> > > 
> > > the driver won't work anymore and all boards which use an
> > 
> > environment in an
> > 
> > > SPI flash will fail booting.
> > 
> > Sorry i don't know how you track patches that should be applied for
> > the RC.
> > But IMHO this is one :)
> 
> Thanks Michael
> I will take care of that.
Ping :)

-- 
Michael

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-01-02 18:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-17 17:28 [U-Boot] [PATCH] kirkwood_spi: fix setting of irq mask Michael Walle
2011-12-17 17:31 ` Michael Walle
2011-12-18  1:57   ` Prafulla Wadaskar
2012-01-02 18:38     ` Michael Walle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox