From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sat, 17 Dec 2011 21:00:35 +0100 Subject: [U-Boot] [PATCH] net: Fix arguments in tftpput command In-Reply-To: <1324095888-22757-1-git-send-email-sjg@chromium.org> References: <1324095888-22757-1-git-send-email-sjg@chromium.org> Message-ID: <20111217200035.7B2951ECC61@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Simon Glass, In message <1324095888-22757-1-git-send-email-sjg@chromium.org> you wrote: > The switch to strict_strtoul() was not done correctly - this fixes > the compile error when CONFIG_CMD_TFTPPUT is active. > > Signed-off-by: Simon Glass > --- > common/cmd_net.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/cmd_net.c b/common/cmd_net.c > index f89a24b..be7cc01 100644 > --- a/common/cmd_net.c > +++ b/common/cmd_net.c > @@ -221,8 +221,8 @@ static int netboot_common(enum proto_t proto, cmd_tbl_t *cmdtp, int argc, > > #ifdef CONFIG_CMD_TFTPPUT > case 4: > - save_addr = strict_strtoul(argv[1], NULL, 16); > - save_size = strict_strtoul(argv[2], NULL, 16); > + strict_strtoul(argv[1], 16, &save_addr); > + strict_strtoul(argv[2], 16, &save_size); strict_strtoul() returns error codes. We should not ignore these. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Vulcans believe peace should not depend on force. -- Amanda, "Journey to Babel", stardate 3842.3