public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/cmd_nvedit.c: Fix size calculation in do_env_import()
Date: Sat, 17 Dec 2011 21:05:32 +0100	[thread overview]
Message-ID: <20111217200532.F28D71ECC61@gemini.denx.de> (raw)
In-Reply-To: <1324114390-27290-1-git-send-email-hkronsto@frequentis.com>

Dear Horst Kronstorfer,

In message <1324114390-27290-1-git-send-email-hkronsto@frequentis.com> you wrote:
> do_env_import() missed the final '\0' terminator when calculating the
> size of an environment data block.  This led to an erroneous 'bad CRC,
> import failed' message for a checksum protected environment (-c.)

Can you please describe a test case that shows this bug?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker

  reply	other threads:[~2011-12-17 20:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  9:33 [U-Boot] [PATCH] common/cmd_nvedit.c: Fix size calculation in do_env_import() Horst Kronstorfer
2011-12-17 20:05 ` Wolfgang Denk [this message]
     [not found]   ` <024FE3275EF7814D9B07390F28C0832C63A20CBC@vie196nt.frequentis.frq>
2011-12-19  9:17     ` Wolfgang Denk
2011-12-19  9:19 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111217200532.F28D71ECC61@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox