From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc8xxx: Fix "DRAM" message formatting
Date: Sat, 17 Dec 2011 21:12:10 +0100 [thread overview]
Message-ID: <20111217201210.206F11ECC61@gemini.denx.de> (raw)
In-Reply-To: <1324001689-15226-1-git-send-email-Kyle.D.Moffett@boeing.com>
Dear Kyle Moffett,
In message <1324001689-15226-1-git-send-email-Kyle.D.Moffett@boeing.com> you wrote:
> When the "Detected RDIMM [...]" message was added, it broke the
> pretty-printing of the DRAM information during boot.
>
> It used to look like this:
> DRAM: 2 GiB (DDR2, 64-bit, CL=4, ECC on)
> DDR Chip-Select Interleaving Mode: CS0+CS1
>
> Right now, it looks like this:
> DRAM: Detected RDIMM VL493T5663D-E6M
> 2 GiB (DDR2, 64-bit, CL=4, ECC on)
> DDR Chip-Select Interleaving Mode: CS0+CS1
>
> After this patch, it is:
> DRAM: Detected RDIMM VL493T5663D-E6M
> 2 GiB (DDR2, 64-bit, CL=4, ECC on)
> DDR Chip-Select Interleaving Mode: CS0+CS1
We discussed this before.
This outpout is too verbose. It should read:
DRAM: 2 GiB
And not more. Any additional information should only be printed upon
explicit request from the user.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A verbal contract isn't worth the paper it's written on.
-- Samuel Goldwyn
prev parent reply other threads:[~2011-12-17 20:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 2:14 [U-Boot] [PATCH] mpc8xxx: Fix "DRAM" message formatting Kyle Moffett
2011-12-17 20:12 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111217201210.206F11ECC61@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox