From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 18 Dec 2011 13:54:21 -0500 Subject: [U-Boot] [PATCH 02/16] arch/arm/lib/bootm.c: Optionally use existing atags In-Reply-To: <1324141398-14859-2-git-send-email-pali.rohar@gmail.com> References: <2772527.Czs1Sl5aoH@pali-elitebook> <1324141398-14859-1-git-send-email-pali.rohar@gmail.com> <1324141398-14859-2-git-send-email-pali.rohar@gmail.com> Message-ID: <201112181354.23242.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 17 December 2011 12:03:04 Pali Roh?r wrote: > + s = getenv ("atagaddr"); no space before the "(" > #if defined (CONFIG_SETUP_MEMORY_TAGS) || \ > defined (CONFIG_CMDLINE_TAG) || \ > defined (CONFIG_INITRD_TAG) || \ > defined (CONFIG_SERIAL_TAG) || \ > defined (CONFIG_REVISION_TAG) > ... > +#if defined (CONFIG_SETUP_MEMORY_TAGS) || \ > + defined (CONFIG_CMDLINE_TAG) || \ > + defined (CONFIG_INITRD_TAG) || \ > + defined (CONFIG_SERIAL_TAG) || \ > + defined (CONFIG_REVISION_TAG) rather than duplicating the same list in multiple places, why not setup a local define in this file and then use that everywhere else. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: