public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] km/common: add toolchain variable
Date: Mon, 19 Dec 2011 09:57:20 +0100	[thread overview]
Message-ID: <20111219085720.C3DF8135A9A2@gemini.denx.de> (raw)
In-Reply-To: <4EEEF0D3.5040302@keymile.com>

Dear Holger Brunck,

In message <4EEEF0D3.5040302@keymile.com> you wrote:
> 
> >> +Last change: 24.11.2011
> > 
> > Does this really make any sense?  Which date are you recording here/
> > When you (think) you last edited the file? When you applied the patch
> > to your local tree? When you submitted it for mainline? When it
> > actually got applied?
> 
> What I want to record is to track the version of the scripts and this makes
> sense for me. In the end the scripts are copied into /tftpboot on each
> developers machine and is therefore not under git control. It is an easy
> indication wether the scripts are uptodate or not, without starting a diff tool
> and compare them with the latest git tree. Inside the git tree the information
> is useless, I agree.

You can insert such information when you export the files from git,
say by adding a line like:

	Last commit date: $Format:%H  %cD$

That would IMO make much more sense.

See what we do with "snapshot.commit" in U-Boot [see also the entry
in .git/info/attributes].

> > I recommend to get rid of this, and rather use git revision
> > information instead.
> > 
> 
> I would like to keep this, because git does not easily help here.

Maybe it does - see above.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Committee, n.:  A group of men who individually can do nothing but as
a group decide that nothing can be done.                 - Fred Allen

  reply	other threads:[~2011-12-19  8:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-14 16:11 [U-Boot] [PATCH] km/common: add toolchain variable Holger Brunck
2011-12-17 20:49 ` Wolfgang Denk
2011-12-19  8:07   ` Holger Brunck
2011-12-19  8:57     ` Wolfgang Denk [this message]
2011-12-19 10:37       ` Holger Brunck
2011-12-19 11:33         ` Wolfgang Denk
2011-12-19 12:58           ` Holger Brunck
2011-12-19 15:30             ` Wolfgang Denk
2011-12-20 22:44 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111219085720.C3DF8135A9A2@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox