* [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning
@ 2011-12-19 14:20 Anatolij Gustschin
2011-12-19 15:00 ` Lukasz Majewski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Anatolij Gustschin @ 2011-12-19 14:20 UTC (permalink / raw)
To: u-boot
Fix:
universal.c: In function 's5pc210_phy_control':
universal.c:273:7: warning: 'ret' may be used uninitialized
in this function [-Wuninitialized]
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Cc: Lukasz Majewski <l.majewski@samsung.com>
Cc: Minkyu Kang <mk7.kang@samsung.com>
---
board/samsung/universal_c210/universal.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
index 8393e4f..d0ff834 100644
--- a/board/samsung/universal_c210/universal.c
+++ b/board/samsung/universal_c210/universal.c
@@ -260,7 +260,7 @@ int board_mmc_init(bd_t *bis)
#ifdef CONFIG_USB_GADGET
static int s5pc210_phy_control(int on)
{
- int ret;
+ int ret = 0;
struct pmic *p = get_pmic();
if (pmic_probe(p))
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning
2011-12-19 14:20 [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning Anatolij Gustschin
@ 2011-12-19 15:00 ` Lukasz Majewski
2011-12-19 15:18 ` Anatolij Gustschin
2011-12-20 1:41 ` Minkyu Kang
2011-12-20 22:19 ` Wolfgang Denk
2 siblings, 1 reply; 6+ messages in thread
From: Lukasz Majewski @ 2011-12-19 15:00 UTC (permalink / raw)
To: u-boot
> Fix:
> universal.c: In function 's5pc210_phy_control':
> universal.c:273:7: warning: 'ret' may be used uninitialized
> in this function [-Wuninitialized]
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> board/samsung/universal_c210/universal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/samsung/universal_c210/universal.c
> b/board/samsung/universal_c210/universal.c index 8393e4f..d0ff834
> 100644 --- a/board/samsung/universal_c210/universal.c
> +++ b/board/samsung/universal_c210/universal.c
> @@ -260,7 +260,7 @@ int board_mmc_init(bd_t *bis)
> #ifdef CONFIG_USB_GADGET
> static int s5pc210_phy_control(int on)
> {
> - int ret;
> + int ret = 0;
> struct pmic *p = get_pmic();
>
> if (pmic_probe(p))
Hi Anatolij,
Thank you for pointing me out about the new compiler version.
I've just realized, that I'm still using:
gcc version 4.4.1 (Sourcery G++ Lite 2009q3-68)
My question is about the GCC 4.6 version.
Is it a Codesourcery (Mentor Graphisc), ptxdist Oselas Toolchain,
buildroot (uClibc), linaro, ELDK or a vanilla GCC 4.6 build from source
with custom paramters?
--
Best regards,
Lukasz Majewski
Samsung Poland R&D Center
Platform Group
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning
2011-12-19 15:00 ` Lukasz Majewski
@ 2011-12-19 15:18 ` Anatolij Gustschin
2011-12-19 15:50 ` Wolfgang Denk
0 siblings, 1 reply; 6+ messages in thread
From: Anatolij Gustschin @ 2011-12-19 15:18 UTC (permalink / raw)
To: u-boot
Hi all,
On Mon, 19 Dec 2011 16:00:21 +0100
Lukasz Majewski <l.majewski@samsung.com> wrote:
...
> > diff --git a/board/samsung/universal_c210/universal.c
> > b/board/samsung/universal_c210/universal.c index 8393e4f..d0ff834
> > 100644 --- a/board/samsung/universal_c210/universal.c
> > +++ b/board/samsung/universal_c210/universal.c
> > @@ -260,7 +260,7 @@ int board_mmc_init(bd_t *bis)
> > #ifdef CONFIG_USB_GADGET
> > static int s5pc210_phy_control(int on)
> > {
> > - int ret;
> > + int ret = 0;
> > struct pmic *p = get_pmic();
> >
> > if (pmic_probe(p))
>
> Hi Anatolij,
>
> Thank you for pointing me out about the new compiler version.
>
> I've just realized, that I'm still using:
> gcc version 4.4.1 (Sourcery G++ Lite 2009q3-68)
>
> My question is about the GCC 4.6 version.
> Is it a Codesourcery (Mentor Graphisc), ptxdist Oselas Toolchain,
> buildroot (uClibc), linaro, ELDK or a vanilla GCC 4.6 build from source
> with custom paramters?
I used GCC version 4.2.2 from ELDK 4.2 and GCC version 4.6.1 20110627
from ELDK 5.1 and see this warning with both.
For another patch fixing warnings for s3c_udc_otg driver I
also used same GCC versions, but I see the warnings only
with GCC 4.6.1 from ELDK 5.1. GCC 4.2.2 from ELDK 4.2 didn't
generate any warning when building s3c_udc_otg driver.
Thanks,
Anatolij
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning
2011-12-19 15:18 ` Anatolij Gustschin
@ 2011-12-19 15:50 ` Wolfgang Denk
0 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2011-12-19 15:50 UTC (permalink / raw)
To: u-boot
Dear Lukasz,
In message <20111219161828.7495c109@wker> Anatolij Gustschin wrote:
>
> I used GCC version 4.2.2 from ELDK 4.2 and GCC version 4.6.1 20110627
> from ELDK 5.1 and see this warning with both.
Note: ELDK 5.1 is based on Yocto 1.1 (edison-6.0 release tag), plus
some fixes for ARM related GCC issues. See
http://www.denx.de/wiki/ELDK-5
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
All he had was nothing, but that was something, and now it had been
taken away. - Terry Pratchett, _Sourcery_
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning
2011-12-19 14:20 [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning Anatolij Gustschin
2011-12-19 15:00 ` Lukasz Majewski
@ 2011-12-20 1:41 ` Minkyu Kang
2011-12-20 22:19 ` Wolfgang Denk
2 siblings, 0 replies; 6+ messages in thread
From: Minkyu Kang @ 2011-12-20 1:41 UTC (permalink / raw)
To: u-boot
Dear Remy Bohmer,
On 19 December 2011 23:20, Anatolij Gustschin <agust@denx.de> wrote:
> Fix:
> universal.c: In function 's5pc210_phy_control':
> universal.c:273:7: warning: 'ret' may be used uninitialized
> in this function [-Wuninitialized]
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> ?board/samsung/universal_c210/universal.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/board/samsung/universal_c210/universal.c b/board/samsung/universal_c210/universal.c
> index 8393e4f..d0ff834 100644
> --- a/board/samsung/universal_c210/universal.c
> +++ b/board/samsung/universal_c210/universal.c
> @@ -260,7 +260,7 @@ int board_mmc_init(bd_t *bis)
> ?#ifdef CONFIG_USB_GADGET
> ?static int s5pc210_phy_control(int on)
> ?{
> - ? ? ? int ret;
> + ? ? ? int ret = 0;
> ? ? ? ?struct pmic *p = get_pmic();
>
> ? ? ? ?if (pmic_probe(p))
> --
> 1.7.5.4
>
Acked-by: Minkyu Kang <mk7.kang@samsung.com>
Thanks
Minkyu Kang
--
from. prom.
www.promsoft.net
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning
2011-12-19 14:20 [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning Anatolij Gustschin
2011-12-19 15:00 ` Lukasz Majewski
2011-12-20 1:41 ` Minkyu Kang
@ 2011-12-20 22:19 ` Wolfgang Denk
2 siblings, 0 replies; 6+ messages in thread
From: Wolfgang Denk @ 2011-12-20 22:19 UTC (permalink / raw)
To: u-boot
Dear Anatolij Gustschin,
In message <1324304404-24044-1-git-send-email-agust@denx.de> you wrote:
> Fix:
> universal.c: In function 's5pc210_phy_control':
> universal.c:273:7: warning: 'ret' may be used uninitialized
> in this function [-Wuninitialized]
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Lukasz Majewski <l.majewski@samsung.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> ---
> board/samsung/universal_c210/universal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The shortest unit of time in the multiverse is the News York Second,
defined as the period of time between the traffic lights turning
green and the cab behind you honking.
- Terry Pratchett, _Lords and Ladies_
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-12-20 22:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-19 14:20 [U-Boot] [PATCH] board/samsung/universal_c210/universal.c: Fix build warning Anatolij Gustschin
2011-12-19 15:00 ` Lukasz Majewski
2011-12-19 15:18 ` Anatolij Gustschin
2011-12-19 15:50 ` Wolfgang Denk
2011-12-20 1:41 ` Minkyu Kang
2011-12-20 22:19 ` Wolfgang Denk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox