From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 20 Dec 2011 12:20:40 -0500 Subject: [U-Boot] [PATCH] drivers/net/e1000.c: Fix GCC 4.6 build warnings In-Reply-To: <8469240E-6A43-417F-844C-670CE1D373B5@boeing.com> References: <1324396187-25157-1-git-send-email-agust@denx.de> <8469240E-6A43-417F-844C-670CE1D373B5@boeing.com> Message-ID: <201112201220.40939.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 20 December 2011 11:07:30 Moffett, Kyle D wrote: > On Dec 20, 2011, at 10:49, Anatolij Gustschin wrote: > > #ifdef CONFIG_E1000_FALLBACK_MAC > > - if ( *(u32*)(nic->enetaddr) == 0 || *(u32*)(nic->enetaddr) == ~0 ) { > > + if (get_unaligned_be32(nic->enetaddr) == 0 || > > + get_unaligned_be32(nic->enetaddr) == ~0) { > > > > unsigned char fb_mac[NODE_ADDRESS_SIZE] = CONFIG_E1000_FALLBACK_MAC; > > > > memcpy (nic->enetaddr, fb_mac, NODE_ADDRESS_SIZE); > > No, if you are going to fix this code then make it use the right > function for the job: is_valid_ether_addr() +1 -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: