From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 3/4] mx28: Let dram_init be common for mx28
Date: Tue, 20 Dec 2011 14:57:31 +0100 [thread overview]
Message-ID: <201112201457.32090.marek.vasut@gmail.com> (raw)
In-Reply-To: <1324389212-9208-3-git-send-email-festevam@gmail.com>
> Let dram_init function be a common function, so that other mx28 boards
> can reuse it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v5:
> - Change return value on dram_init()
> Changes since v4:
> - Call mx28_dram_init from m28evk.c
> Changes since v3:
> - Rename dram_init to mx28_dram_init
> arch/arm/cpu/arm926ejs/mx28/mx28.c | 21 +++++++++++++++++++++
> arch/arm/include/asm/arch-mx28/sys_proto.h | 2 ++
> board/denx/m28evk/m28evk.c | 18 +-----------------
> 3 files changed, 24 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> b/arch/arm/cpu/arm926ejs/mx28/mx28.c index 79b4001..722efbf 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/mx28.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/mx28.c
> @@ -262,6 +262,27 @@ void mx28_get_mac_from_fuse(int dev_id, char *mac)
> }
> #endif
>
> +#define HW_DIGCTRL_SCRATCH0 0x8001c280
> +#define HW_DIGCTRL_SCRATCH1 0x8001c290
> +int mx28_dram_init(void)
> +{
> + uint32_t sz[2];
> +
> + sz[0] = readl(HW_DIGCTRL_SCRATCH0);
> + sz[1] = readl(HW_DIGCTRL_SCRATCH1);
> +
> + if (sz[0] != sz[1]) {
> + printf("MX28:\n"
> + "Error, the RAM size in HW_DIGCTRL_SCRATCH0 and\n"
> + "HW_DIGCTRL_SCRATCH1 is not the same. Please\n"
> + "verify these two registers contain valid RAM size!\n");
> + hang();
> + }
> +
> + gd->ram_size = sz[0];
> + return 0;
> +}
> +
> U_BOOT_CMD(
> clocks, CONFIG_SYS_MAXARGS, 1, do_mx28_showclocks,
> "display clocks",
> diff --git a/arch/arm/include/asm/arch-mx28/sys_proto.h
> b/arch/arm/include/asm/arch-mx28/sys_proto.h index be1f7db..f101494 100644
> --- a/arch/arm/include/asm/arch-mx28/sys_proto.h
> +++ b/arch/arm/include/asm/arch-mx28/sys_proto.h
> @@ -35,4 +35,6 @@ void mx28_common_spl_init(const iomux_cfg_t *iomux_setup,
> const unsigned int iomux_size);
> #endif
>
> +int mx28_dram_init(void);
> +
> #endif /* __MX28_H__ */
> diff --git a/board/denx/m28evk/m28evk.c b/board/denx/m28evk/m28evk.c
> index 005446a..53df476 100644
> --- a/board/denx/m28evk/m28evk.c
> +++ b/board/denx/m28evk/m28evk.c
> @@ -70,25 +70,9 @@ int board_init(void)
> return 0;
> }
>
> -#define HW_DIGCTRL_SCRATCH0 0x8001c280
> -#define HW_DIGCTRL_SCRATCH1 0x8001c290
> int dram_init(void)
> {
> - uint32_t sz[2];
> -
> - sz[0] = readl(HW_DIGCTRL_SCRATCH0);
> - sz[1] = readl(HW_DIGCTRL_SCRATCH1);
> -
> - if (sz[0] != sz[1]) {
> - printf("MX28:\n"
> - "Error, the RAM size in HW_DIGCTRL_SCRATCH0 and\n"
> - "HW_DIGCTRL_SCRATCH1 is not the same. Please\n"
> - "verify these two registers contain valid RAM size!\n");
> - hang();
> - }
> -
> - gd->ram_size = sz[0];
> - return 0;
> + return mx28_dram_init();
> }
>
> #ifdef CONFIG_CMD_MMC
Acked-by: Marek Vasut <marek.vasut@gmail.com>
next prev parent reply other threads:[~2011-12-20 13:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 13:53 [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28 Fabio Estevam
2011-12-20 13:53 ` [U-Boot] [PATCH v6 2/4] mx28: Allow to set MAC address for the two FECs Fabio Estevam
2011-12-20 13:57 ` Marek Vasut
2011-12-20 14:39 ` Stefano Babic
2011-12-20 13:53 ` [U-Boot] [PATCH v6 3/4] mx28: Let dram_init be common for mx28 Fabio Estevam
2011-12-20 13:57 ` Marek Vasut [this message]
2011-12-20 13:53 ` [U-Boot] [PATCH v6 4/4] mx28evk: Add initial support for MX28EVK board Fabio Estevam
2011-12-20 13:58 ` Marek Vasut
2011-12-28 12:20 ` Fabio Estevam
2011-12-28 12:36 ` Stefano Babic
2011-12-28 12:46 ` Fabio Estevam
2011-12-28 13:04 ` Fabio Estevam
2011-12-28 13:12 ` Stefano Babic
2011-12-28 12:37 ` Stefano Babic
2011-12-20 13:55 ` [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be common for mx28 Marek Vasut
2011-12-20 14:43 ` Veli-Pekka Peltola
2011-12-20 14:45 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112201457.32090.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox