From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Tue, 20 Dec 2011 15:45:37 +0100
Subject: [U-Boot] [PATCH v6 1/4] mx28: Let imx_get_mac_from_fuse be
	common for mx28
In-Reply-To: <4EF09F01.3080308@bluegiga.com>
References: <1324389212-9208-1-git-send-email-festevam@gmail.com>
	<201112201455.36738.marek.vasut@gmail.com>
	<4EF09F01.3080308@bluegiga.com>
Message-ID: <201112201545.37552.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On 12/20/2011 03:55 PM, Marek Vasut wrote:
> >> Let imx_get_mac_from_fuse function be a common function, so that other
> >> mx28 boards can reuse it.
> 
> [snip]
> 
> >> +static void __set_mac_vendor(char *mac)
> 
> [snip]
> 
> > It's good, but why not make it completely generic -- like
> > mx28_adjust_mac() -- so the users can for example change the last bit of
> > the mac depending on the NIC that's used (FEC0 or FEC1). I think I
> > proposed that. It's only a matter of adding a parameter (nic #) and
> > renaming it :)
> 
> What is stored in MX28EVK CUST1 fuse? It seems to be CUST0 increased by
> one. So maybe we should read it from there for FEC1?
> 
> It would be nice to have very generic fuse reading function that could
> be used to read a serial number or similar user data. I will work this
> out if you don't like to do it. I'm quite busy now so it might take a
> week or two.

The release'll be early xmas present from Wolfgang, so you have those two weeks 
no problem ;-) Please go ahead and do it.

Thanks!

M