From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Tue, 20 Dec 2011 17:35:31 +0100
Subject: [U-Boot] [PATCH] drivers/net/e1000_spi.c: Fix build warnings
In-Reply-To: <8A6AE127-0EBD-4945-AD91-45B1FDDEAAED@boeing.com>
References: <1324384143-10198-1-git-send-email-agust@denx.de>
	<8A6AE127-0EBD-4945-AD91-45B1FDDEAAED@boeing.com>
Message-ID: <20111220173531.1f2b788d@wker>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 20 Dec 2011 10:19:51 -0600
"Moffett, Kyle D" <Kyle.D.Moffett@boeing.com> wrote:

> On Dec 20, 2011, at 07:29, Anatolij Gustschin wrote:
> > Fix:
> > e1000_spi.c: In function 'spi_free_slave':
> > e1000_spi.c:115: warning: unused variable 'hw'
> > e1000_spi.c: In function 'do_e1000_spi':
> > e1000_spi.c:472: warning: 'checksum' may be used uninitialized in this function
> > e1000_spi.c:472: note: 'checksum' was declared here
> 
> Acked-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
> 
> This is great, thanks!
> 
> I actually thought that the "checksum" fix had already made it
> into Wolfgang's tree, but I can't find it now that I'm looking
> for it.

There is a "checksum" fix in Wolfgang's tree, commit 7a341066
(e1000: fix bugs from recent commits). It is for drivers/net/e1000.c
file, however.

> The really frustrating thing is that on my test system I have
> seen the "unused variable" warning for a while now (although I
> was not sure what to do about it), but despite the fact that
> the "checksum" variable is very clearly improperly initialized
> I don't get that warning out of my compiler.
> 
> Oh, right, I'm using GCC 4.4 right now and it needs 4.6+

I've seen this warning with GCC 4.2.2 and GCC 4.6.1.

Thanks,
Anatolij