From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver
Date: Wed, 21 Dec 2011 00:09:23 +0100 [thread overview]
Message-ID: <20111220230923.A06F2822DA@gemini.denx.de> (raw)
In-Reply-To: <4EF11209.5050102@gmail.com>
Dear Rob Herring,
In message <4EF11209.5050102@gmail.com> you wrote:
>
> > Are there going to be any users for this driver?
>
> Yes. Patch 2/2 adds support to Calxeda Highbank.
I saw this myself 5 seconds later, but my "send" button has no "undo"
function ;-) Sorry...
> > Checkpatch says:
> >
> > WARNING: __aligned(size) is preferred over __attribute__((aligned(size)))
> > #461: FILE: drivers/net/calxedaxgmac.c:317:
> > +} __attribute__((aligned(32)));
> >
> > Is there any special reason not to change this?
>
> I thought it was a false positive because I didn't find any other users
> of __aligned().
I think we should change this. [I can do this when applying, if you
like.]
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What the gods would destroy they first submit to an IEEE standards
committee.
next prev parent reply other threads:[~2011-12-20 23:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 20:21 [U-Boot] [PATCH 0/2] Network support for Calxeda highbank Rob Herring
2011-12-02 20:21 ` [U-Boot] [PATCH 1/2] net: add Calxeda xgmac driver Rob Herring
2011-12-02 21:30 ` Mike Frysinger
2011-12-02 22:02 ` Rob Herring
2011-12-02 22:14 ` Mike Frysinger
2011-12-02 22:46 ` Rob Herring
2011-12-02 23:54 ` Mike Frysinger
2011-12-02 20:21 ` [U-Boot] [PATCH 2/2] ARM: highbank: enable networking and pxe Rob Herring
2011-12-02 21:31 ` Mike Frysinger
2011-12-02 22:03 ` Rob Herring
2011-12-02 22:15 ` Mike Frysinger
2011-12-07 17:56 ` [U-Boot] [PATCH v2 1/2] net: add Calxeda xgmac driver Rob Herring
2011-12-07 17:56 ` [U-Boot] [PATCH v2 2/2] ARM: highbank: enable networking and pxe Rob Herring
2011-12-09 4:00 ` Mike Frysinger
2011-12-09 3:56 ` [U-Boot] [PATCH v2 1/2] net: add Calxeda xgmac driver Mike Frysinger
2011-12-15 21:15 ` [U-Boot] [PATCH v3 " Rob Herring
2011-12-15 21:15 ` [U-Boot] [PATCH v3 2/2] ARM: highbank: enable networking and pxe Rob Herring
2012-01-05 16:32 ` Wolfgang Denk
2011-12-20 22:42 ` [U-Boot] [PATCH v3 1/2] net: add Calxeda xgmac driver Wolfgang Denk
2011-12-20 22:54 ` Rob Herring
2011-12-20 23:09 ` Wolfgang Denk [this message]
2011-12-20 23:12 ` Rob Herring
2012-01-05 16:31 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220230923.A06F2822DA@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox