From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: add CONFIG_USB_INIT to autoinitialize USB before main_loop
Date: Fri, 23 Dec 2011 00:00:08 +0100 [thread overview]
Message-ID: <20111222230008.60AF61F0793@gemini.denx.de> (raw)
In-Reply-To: <3C7A7ACA8617D24290826EC008B5CD083E5DCDAF40@HQMAIL03.nvidia.com>
Dear Allen Martin,
In message <3C7A7ACA8617D24290826EC008B5CD083E5DCDAF40@HQMAIL03.nvidia.com> you wrote:
>
> I don't fully grok how console/stdin gets assigned, but is this possibly
> the problem? (from drv_usb_kbd_init()):
>
> /* Check if this is the standard input device. */
> if (strcmp(stdinname, DEVNAME))
> return 1;
>
> /* Reassign the console */
> if (overwrite_console())
> return 1;
>
> error = console_assign(stdin, DEVNAME);
>
> This seems incompatible with iomux, shouldn't these decisions be made in the
> console driver? In my case, stdin is set to "serial,tegra-kbc,usbkbd" so this
> strcmp won't match.
Indeed, this code predates the iomux implementation, and nobody
noticed yet that it needs fixing.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
They're usually so busy thinking about what happens next that the
only time they ever find out what is happening now is when they come
to look back on it. - Terry Pratchett, _Wyrd Sisters_
next prev parent reply other threads:[~2011-12-22 23:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 1:05 [U-Boot] [PATCH] USB: add CONFIG_USB_INIT to autoinitialize USB before main_loop Allen Martin
2011-12-22 4:04 ` Marek Vasut
2011-12-22 18:54 ` Allen Martin
2011-12-22 19:10 ` Moffett, Kyle D
2011-12-22 19:27 ` Marek Vasut
2011-12-22 20:32 ` Allen Martin
2011-12-22 22:40 ` Allen Martin
2011-12-22 23:00 ` Wolfgang Denk [this message]
2011-12-22 8:06 ` Wolfgang Denk
2011-12-22 8:17 ` Igor Grinberg
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 22:25 Allen Martin
2011-12-23 0:52 Allen Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222230008.60AF61F0793@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox