From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean
Date: Fri, 23 Dec 2011 20:07:23 +0100 [thread overview]
Message-ID: <20111223190723.39EC2166C892@gemini.denx.de> (raw)
In-Reply-To: <20111223133952.5e09a8b4@wker>
Dear Anatolij Gustschin,
In message <20111223133952.5e09a8b4@wker> you wrote:
>
> Looks good. A minor commend below.
...
> > -extern void cpu_post_exec_02 (ulong *code, ulong op1, ulong op2);
> > +extern void cpu_post_exec_02(ulong * code, ulong op1, ulong op2);
>
> IIRC checkpatch complains like "foo * bar" should be "foo *bar",
> There is surely no need to resubmit the patch, it could be changed
> when applying. Otherwise
You are right. Fixed this. Thanks for the review!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Science makes godlike -- it is all over with priests and gods when
man becomes scientific. Moral: science is the forbidden as such -- it
alone is forbidden. Science is the *first* sin, the *original* sin.
*This alone is morality.* ``Thou shalt not know'' -- the rest
follows." - Friedrich Nietzsche
next prev parent reply other threads:[~2011-12-23 19:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 23:21 [U-Boot] CPU POST on MPC5200 fails with U-Boot built using GCC 4.6.1 Anatolij Gustschin
2011-12-23 11:29 ` [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean Wolfgang Denk
2011-12-23 11:29 ` [U-Boot] [PATCH 2/3] post/lib_powerpc/multi.c: code cleanup Wolfgang Denk
2011-12-23 12:45 ` Anatolij Gustschin
2011-12-23 19:07 ` Wolfgang Denk
2011-12-23 11:29 ` [U-Boot] [PATCH 3/3] post/lib_powerpc/multi.c: fix stack overflow error Wolfgang Denk
2011-12-23 16:06 ` Anatolij Gustschin
2011-12-23 19:10 ` Wolfgang Denk
2011-12-23 19:08 ` Wolfgang Denk
2011-12-23 12:39 ` [U-Boot] [PATCH 1/3] post/lib_powerpc/multi.c: make checkpatch clean Anatolij Gustschin
2011-12-23 19:07 ` Wolfgang Denk [this message]
2011-12-23 19:06 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111223190723.39EC2166C892@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox