From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [trivial] env: remove value from boolean defines
Date: Mon, 26 Dec 2011 00:34:47 +0100 [thread overview]
Message-ID: <201112260034.47936.marek.vasut@gmail.com> (raw)
In-Reply-To: <1324813377-16764-1-git-send-email-grinberg@compulab.co.il>
> Several boolean defines have a value assigned.
> Remove the value as defining the symbol is enough.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
I'm fine with this. How did you find it ?
M
> ---
> include/environment.h | 8 ++++----
> tools/envcrc.c | 6 +++---
> 2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/include/environment.h b/include/environment.h
> index 3c145af..1ef44f3 100644
> --- a/include/environment.h
> +++ b/include/environment.h
> @@ -22,7 +22,7 @@
> */
>
> #ifndef _ENVIRONMENT_H_
> -#define _ENVIRONMENT_H_ 1
> +#define _ENVIRONMENT_H_
>
> /*************************************************************************
> * *
> @@ -64,10 +64,10 @@
> # if (CONFIG_ENV_ADDR >= CONFIG_SYS_MONITOR_BASE) && \
> (CONFIG_ENV_ADDR + CONFIG_ENV_SIZE) <= \
> (CONFIG_SYS_MONITOR_BASE + CONFIG_SYS_MONITOR_LEN)
> -# define ENV_IS_EMBEDDED 1
> +# define ENV_IS_EMBEDDED
> # endif
> # if defined(CONFIG_ENV_ADDR_REDUND) || defined(CONFIG_ENV_OFFSET_REDUND)
> -# define CONFIG_SYS_REDUNDAND_ENVIRONMENT 1
> +# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> # endif
> # ifdef CONFIG_ENV_IS_EMBEDDED
> # error "do not define CONFIG_ENV_IS_EMBEDDED in your board config"
> @@ -120,7 +120,7 @@ extern unsigned long nand_env_oob_offset;
> * calculated automatically (i.e. NAND), take the board opt-in.
> */
> #if defined(CONFIG_ENV_IS_EMBEDDED) && !defined(ENV_IS_EMBEDDED)
> -# define ENV_IS_EMBEDDED 1
> +# define ENV_IS_EMBEDDED
> #endif
>
> /* The build system likes to know if the env is embedded */
> diff --git a/tools/envcrc.c b/tools/envcrc.c
> index 51e3f54..08d2a8f 100644
> --- a/tools/envcrc.c
> +++ b/tools/envcrc.c
> @@ -53,15 +53,15 @@
> # endif
> # if (CONFIG_ENV_ADDR >= CONFIG_SYS_MONITOR_BASE) && \
> ((CONFIG_ENV_ADDR + CONFIG_ENV_SIZE) <= (CONFIG_SYS_MONITOR_BASE +
> CONFIG_SYS_MONITOR_LEN)) -# define ENV_IS_EMBEDDED 1
> +# define ENV_IS_EMBEDDED
> # endif
> # if defined(CONFIG_ENV_ADDR_REDUND) || defined(CONFIG_ENV_OFFSET_REDUND)
> -# define CONFIG_SYS_REDUNDAND_ENVIRONMENT 1
> +# define CONFIG_SYS_REDUNDAND_ENVIRONMENT
> # endif
> #endif /* CONFIG_ENV_IS_IN_FLASH */
>
> #if defined(ENV_IS_EMBEDDED) && !defined(CONFIG_BUILD_ENVCRC)
> -# define CONFIG_BUILD_ENVCRC 1
> +# define CONFIG_BUILD_ENVCRC
> #endif
>
> #ifdef CONFIG_SYS_REDUNDAND_ENVIRONMENT
next prev parent reply other threads:[~2011-12-25 23:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-25 11:42 [U-Boot] [PATCH] [trivial] env: remove value from boolean defines Igor Grinberg
2011-12-25 23:34 ` Marek Vasut [this message]
2011-12-26 6:17 ` Igor Grinberg
2011-12-26 14:17 ` Marek Vasut
2011-12-26 15:05 ` Igor Grinberg
2011-12-26 16:16 ` Marek Vasut
2011-12-31 23:05 ` Mike Frysinger
2012-01-05 15:36 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112260034.47936.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox