public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [trivial] env: remove value from boolean defines
Date: Mon, 26 Dec 2011 17:16:19 +0100	[thread overview]
Message-ID: <201112261716.19686.marek.vasut@gmail.com> (raw)
In-Reply-To: <4EF88D2A.60001@compulab.co.il>

> On 12/26/11 16:17, Marek Vasut wrote:
> >> On 12/26/11 01:34, Marek Vasut wrote:
> >>>> Several boolean defines have a value assigned.
> >>>> Remove the value as defining the symbol is enough.
> >>>> 
> >>>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> >>> 
> >>> I'm fine with this. How did you find it ?
> >> 
> >> Occasionally...
> >> I told you (at the KS) I'm working on something environment related.
> >> I hope to post it soon (before the end of the merge window).
> > 
> > Ack
> 
> Want to send a proper Ack, so patchwork will catch it?
> Or may be apply to marek.vasut at gmail.com branch of u-boot-staging?
> Or may be both...

No, I only acked the explanation, I'd like others to comment on this patch 
before it's actually applied.

But grepping through the tree, I think it won't break anything, so

Acked-by: Marek Vasut <marek.vasut@gmail.com>

  reply	other threads:[~2011-12-26 16:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-25 11:42 [U-Boot] [PATCH] [trivial] env: remove value from boolean defines Igor Grinberg
2011-12-25 23:34 ` Marek Vasut
2011-12-26  6:17   ` Igor Grinberg
2011-12-26 14:17     ` Marek Vasut
2011-12-26 15:05       ` Igor Grinberg
2011-12-26 16:16         ` Marek Vasut [this message]
2011-12-31 23:05 ` Mike Frysinger
2012-01-05 15:36 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112261716.19686.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox