public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mtd/nand:Fix wrong address read in is_blank()
Date: Wed, 28 Dec 2011 08:28:54 +0100	[thread overview]
Message-ID: <201112280828.54733.marek.vasut@gmail.com> (raw)
In-Reply-To: <071A08F2C6A57E4E94D980ECA553F874485539@039-SN1MPN1-006.039d.mgd.msft.net>

> > > IFC NAND Machine calculates ECC on 512byte sector. Same is taken care
> > > in
> > > fsl_ifc_run_command() while ECC status verification. Here buffer
> > > number is calculated assuming 512byte sector and same is passed to
> > 
> > is_blank.
> > 
> > > However in is_blank() buffer address is calculated using
> > > mdt->writesize which is wrong. It should be calculated on basis of ecc
> > 
> > sector size.
> > 
> > > Also, in fsl_ifc_run_command() bufferpage is calculated on the basis
> > > of ecc sector size instead of hard coded value.
> > > 
> > > Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > 
> > You just sent two patches based on the same commit, but those are clearly
> > dependent. This is weird. So next time:
> > 
> > 1) Submit this with git-send-email as a series
> 
> I will take care this point in future
> 
> > 2) iomem looks linuxish, so instead of specifying u-boot commit, specify
> > Linux commit/tree etc. from where this is pulled so when someone synces
> > next time, he'll know where he is in linux.
> 
> This patch is independent of Linux tree. I will float similar patch to
> Linux tree.
> 
> > 3) Cc Scott Wood
> 
> I will take care this point in future
> 
> --Prabhakar

Awesome, good going, thanks!

M

  reply	other threads:[~2011-12-28  7:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-28  5:22 [U-Boot] [PATCH 1/2] mtd/nand:Fix wrong address read in is_blank() Prabhakar Kushwaha
2011-12-28  6:48 ` Marek Vasut
2011-12-28  7:21   ` Kushwaha Prabhakar-B32579
2011-12-28  7:28     ` Marek Vasut [this message]
2012-01-04 21:52 ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201112280828.54733.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox