From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 28 Dec 2011 08:28:54 +0100
Subject: [U-Boot] [PATCH 1/2] mtd/nand:Fix wrong address read in
	is_blank()
In-Reply-To: <071A08F2C6A57E4E94D980ECA553F874485539@039-SN1MPN1-006.039d.mgd.msft.net>
References: <1325049770-7327-1-git-send-email-prabhakar@freescale.com>
	<201112280748.32636.marek.vasut@gmail.com>
	<071A08F2C6A57E4E94D980ECA553F874485539@039-SN1MPN1-006.039d.mgd.msft.net>
Message-ID: <201112280828.54733.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> > > IFC NAND Machine calculates ECC on 512byte sector. Same is taken care
> > > in
> > > fsl_ifc_run_command() while ECC status verification. Here buffer
> > > number is calculated assuming 512byte sector and same is passed to
> > 
> > is_blank.
> > 
> > > However in is_blank() buffer address is calculated using
> > > mdt->writesize which is wrong. It should be calculated on basis of ecc
> > 
> > sector size.
> > 
> > > Also, in fsl_ifc_run_command() bufferpage is calculated on the basis
> > > of ecc sector size instead of hard coded value.
> > > 
> > > Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> > > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > 
> > You just sent two patches based on the same commit, but those are clearly
> > dependent. This is weird. So next time:
> > 
> > 1) Submit this with git-send-email as a series
> 
> I will take care this point in future
> 
> > 2) iomem looks linuxish, so instead of specifying u-boot commit, specify
> > Linux commit/tree etc. from where this is pulled so when someone synces
> > next time, he'll know where he is in linux.
> 
> This patch is independent of Linux tree. I will float similar patch to
> Linux tree.
> 
> > 3) Cc Scott Wood
> 
> I will take care this point in future
> 
> --Prabhakar

Awesome, good going, thanks!

M