[U-Boot] [PATCH] m28evk: Use GENERATED_GBL_DATA_SIZE

Marek Vasut
2011-12-29T18:22:32Z

> On 29/12/2011 16:22, Marek Vasut wrote:
> >> Use GENERATED_GBL_DATA_SIZE for calculating CONFIG_SYS_INIT_SP_OFFSET.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Maybe I'd be better to consolidate the i.MX28 config to a common config
> > file and have only board specific stuff in the board-specific configs,
> > which would in turn include the file?
>
> But this issue is not strictly related only to MX28. The same is for any
> SOC in u-boot, and most of CONFIG_ are duplicated in the configuration
> files for boards having the same SOC.
>
> At the moment, we do this only for slightly different boards (imx27lite
> and magnesium, for example) or for boards having the same SOM.
>
> Agree we can rationalize better, but it should be discussed if we plan
> to introduce some hierarchy in the configuration files - the board
> configuration file can include a SOC configuration file, that can
> include a ARCH configuration file....
>
> Apart of that, I think it is not bad to merge this Fabio's patch - it
> makes the board consistent with the other ones.

Fine by me, but I can't test it.

M

>
> Best regards,
> Stefano Babic