[U-Boot] [PATCH] lsxl: add support for lschlv2 and lsxhl

Wolfgang Denk
2012-01-02T23:55:41Z

Dear Michael Walle,

In message <1325545909-17678-1-git-send-email-michael@walle.cc> you wrote:
> This patchset adds support for both the Linkstation Live (LS-CHLv2) and
> Linkstation Pro (LS-XHL) by Buffalo.

If Buffalo is the vendor, then why do you add this to the Marvell
vendor directory?

> +Michael Walle <michael@walle.cc>
> +
> + lsxl ARM926EJS (Kirkwood SoC)

You add two boards, so please also maintain both.

> +#define CONFIG_FEROCEON_88FR131 1 /* CPU Core subversion */
> +#define CONFIG_KIRKWOOD 1 /* SOC Family Name */
> +#define CONFIG_KW88F6281 1 /* SOC Name */

Please don't define values for macros that select featues only.
Please fix globally.

> +#ifdef CONFIG_SPI_FLASH
> +#define CONFIG_SYS_MAX_FLASH_BANKS 1
> +#define CONFIG_SYS_MAX_FLASH_SECT 8
> +#define CONFIG_ENV_IS_IN_SPI_FLASH 1
> +#define CONFIG_ENV_SECT_SIZE 0x10000 /* 64K */
> +#else
> +#define CONFIG_ENV_IS_NOWHERE 1 /* if env in SDRAM */
> +#endif
> +#define CONFIG_ENV_SIZE 0x10000 /* 64k */
> +#define CONFIG_ENV_OFFSET 0x70000 /* env starts here */

Please use TABs only for vertical alignment. Please fix globally.

> +#define CONFIG_ETHADDR 02:00:01:00:00:00
...
> +#define CONFIG_IPADDR 192.168.11.150
> +#define CONFIG_SERVERIP 192.168.11.1
> +#define CONFIG_NETMASK 255.255.255.0

NAK. We do not allow such static network configurations.

> +#define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/sda2 " \
> + "netconsole=@"MK_STR(CONFIG_IPADDR)"/eth1"
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> + "bootsource=hdd\0" \
> + "hdpart=0:1\0" \
> + "bootcmd_net=tftpboot 0x00100000 uImage; " \
> + "tftpboot 0x00800000 uInitrd; " \
> + "bootm 0x00100000 0x00800000\0" \
> + "bootcmd_hdd=ide reset; ext2load ide ${hdpart} 0x00100000 /uImage; " \
> + "ext2load ide ${hdpart} 0x00800000 /uInitrd; " \
> + "bootm 0x00100000 0x00800000\0" \

Indentation by TAB only, please. Please fix globally.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The more sins you confess, the more books you will sell.