From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] fw_env.c: use default env values if config file cannot be opened
Date: Thu, 05 Jan 2012 16:16:31 +0100 [thread overview]
Message-ID: <20120105151631.9ABBA1FD3DA@gemini.denx.de> (raw)
In-Reply-To: <1325098913-29909-1-git-send-email-fransmeulenbroeks@gmail.com>
Dear Frans Meulenbroeks,
In message <1325098913-29909-1-git-send-email-fransmeulenbroeks@gmail.com> you wrote:
> If the config file cannot be opened currently one gets an error
> even though the build in names/sizes are probably ok.
> By setting the default values first and only exit if there
> is a read error and not when the config file can be opened
> the program will try the default settings.
I have to admit that I don't like this change of behaviour. When
configured for use with a config file, all errors should be treated
the same.
But that's just my $ 0.02.
Are there any other opinions / votes how to proceed here?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Artificial Intelligence is no match for natural stupidity.
next prev parent reply other threads:[~2012-01-05 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 19:01 [U-Boot] [PATCH] fw_env.c: use default env values if config file cannot be opened Frans Meulenbroeks
2012-01-05 15:16 ` Wolfgang Denk [this message]
2012-01-05 15:41 ` Frans Meulenbroeks
2012-02-12 20:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105151631.9ABBA1FD3DA@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox