From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 05 Jan 2012 16:16:31 +0100 Subject: [U-Boot] [PATCH] fw_env.c: use default env values if config file cannot be opened In-Reply-To: <1325098913-29909-1-git-send-email-fransmeulenbroeks@gmail.com> References: <1325098913-29909-1-git-send-email-fransmeulenbroeks@gmail.com> Message-ID: <20120105151631.9ABBA1FD3DA@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Frans Meulenbroeks, In message <1325098913-29909-1-git-send-email-fransmeulenbroeks@gmail.com> you wrote: > If the config file cannot be opened currently one gets an error > even though the build in names/sizes are probably ok. > By setting the default values first and only exit if there > is a read error and not when the config file can be opened > the program will try the default settings. I have to admit that I don't like this change of behaviour. When configured for use with a config file, all errors should be treated the same. But that's just my $ 0.02. Are there any other opinions / votes how to proceed here? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Artificial Intelligence is no match for natural stupidity.