From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] env: factor out the env_get_char_spec() function
Date: Thu, 05 Jan 2012 16:35:03 +0100 [thread overview]
Message-ID: <20120105153503.E44201FD3DA@gemini.denx.de> (raw)
In-Reply-To: <1324906390-26264-1-git-send-email-grinberg@compulab.co.il>
Dear Igor Grinberg,
In message <1324906390-26264-1-git-send-email-grinberg@compulab.co.il> you wrote:
> env_get_char_spec() function is duplicated across multiple environment
> files.
> Remove the duplication by providing a default implementation.
> Add "weak" declaration, so the default implementation can be overridden.
>
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> common/env_common.c | 7 +++++++
> common/env_flash.c | 5 -----
> common/env_mgdisk.c | 5 -----
> common/env_mmc.c | 5 -----
> common/env_nand.c | 5 -----
> common/env_nowhere.c | 5 -----
> common/env_nvram.c | 6 ++----
> common/env_onenand.c | 5 -----
> common/env_sf.c | 5 -----
> 9 files changed, 9 insertions(+), 39 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It all seemed, he thought, to be rather a lot of trouble to go to
just sharpen a razor blade. - Terry Pratchett, _The Light Fantastic_
prev parent reply other threads:[~2012-01-05 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 13:33 [U-Boot] [PATCH] env: factor out the env_get_char_spec() function Igor Grinberg
2012-01-05 15:35 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105153503.E44201FD3DA@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox