From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 05 Jan 2012 16:35:03 +0100 Subject: [U-Boot] [PATCH] env: factor out the env_get_char_spec() function In-Reply-To: <1324906390-26264-1-git-send-email-grinberg@compulab.co.il> References: <1324906390-26264-1-git-send-email-grinberg@compulab.co.il> Message-ID: <20120105153503.E44201FD3DA@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Igor Grinberg, In message <1324906390-26264-1-git-send-email-grinberg@compulab.co.il> you wrote: > env_get_char_spec() function is duplicated across multiple environment > files. > Remove the duplication by providing a default implementation. > Add "weak" declaration, so the default implementation can be overridden. > > Signed-off-by: Igor Grinberg > --- > common/env_common.c | 7 +++++++ > common/env_flash.c | 5 ----- > common/env_mgdisk.c | 5 ----- > common/env_mmc.c | 5 ----- > common/env_nand.c | 5 ----- > common/env_nowhere.c | 5 ----- > common/env_nvram.c | 6 ++---- > common/env_onenand.c | 5 ----- > common/env_sf.c | 5 ----- > 9 files changed, 9 insertions(+), 39 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It all seemed, he thought, to be rather a lot of trouble to go to just sharpen a razor blade. - Terry Pratchett, _The Light Fantastic_