public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 3/3] usb_storage: Fix EHCI "out of buffer pointers" with CD-ROM
Date: Thu, 05 Jan 2012 17:16:27 +0100	[thread overview]
Message-ID: <20120105161627.D7A7A1FD3DA@gemini.denx.de> (raw)
In-Reply-To: <1324487292-7299-4-git-send-email-Kyle.D.Moffett@boeing.com>

Dear Kyle Moffett,

In message <1324487292-7299-4-git-send-email-Kyle.D.Moffett@boeing.com> you wrote:
> When performing large bulk reads from a CD or DVD using the U-Boot
> usb_storage driver, it generates requests of up to 20 blocks at a time.
> 
> With a standard 512-byte block size, that is 10240 bytes and within the
> limit of U-Boot's EHCI driver (maximum 5 pages at 4k per page).
> 
> Unfortunately CD-ROM media has a 2048-byte blocksize, resulting in a
> maximum transfer size of 40960 bytes, which does not fit.
> 
> Since the EHCI specification is impossibly obtuse and far beyond my
> comprehension, I chose to dynamically compute the limit based on the
> blocksize.
> 
> Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
> 
> --
> 
> v2:
> Minor whitespace fixes
> 
> ---
>  common/usb_storage.c |   45 +++++++++++++++++++++++++--------------------
>  1 files changed, 25 insertions(+), 20 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"An organization dries up if you don't challenge it with growth."
       - Mark Shepherd, former President and CEO of Texas Instruments

  reply	other threads:[~2012-01-05 16:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21 17:08 [U-Boot] [PATCH v2 0/3] Enable access to FAT filesystem in an ISO9660 El-Torito volume Kyle Moffett
2011-12-21 17:08 ` [U-Boot] [PATCH v2 1/3] fs/fat: Fix FAT detection to support non-DOS partition tables Kyle Moffett
2012-01-05 16:14   ` Wolfgang Denk
2012-01-05 19:12   ` Wolfgang Denk
2011-12-21 17:08 ` [U-Boot] [PATCH v2 2/3] fs/fat: Improve error handling Kyle Moffett
2012-01-05 16:15   ` Wolfgang Denk
2011-12-21 17:08 ` [U-Boot] [PATCH v2 3/3] usb_storage: Fix EHCI "out of buffer pointers" with CD-ROM Kyle Moffett
2012-01-05 16:16   ` Wolfgang Denk [this message]
2012-02-26 23:08 ` [U-Boot] [PATCH v2 0/3] Enable access to FAT filesystem in an ISO9660 El-Torito volume Marek Vasut
2012-03-30 21:03   ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105161627.D7A7A1FD3DA@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox