public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] avoid flash writes for new keys, with no values with fw_setenv
Date: Thu, 05 Jan 2012 17:19:12 +0100	[thread overview]
Message-ID: <20120105161912.EFB2F1FD3DA@gemini.denx.de> (raw)
In-Reply-To: <1324457962.60605.YahooMailNeo@web120203.mail.ne1.yahoo.com>

Dear Sridhar Addagada,

In message <1324457962.60605.YahooMailNeo@web120203.mail.ne1.yahoo.com> you wrote:
>
> This will avoid flash writes for fw_setenv command where the key is not present the environment and no value has been provided.

Line too long.  And your patch is white space corrupted.  Please fix
your mailer, or better use git-format-patch and git-send-email instead.

Also, make sure to always call fw_env_close().

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If there are self-made purgatories, then we all have to live in them.
	-- Spock, "This Side of Paradise", stardate 3417.7

      reply	other threads:[~2012-01-05 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21  8:59 [U-Boot] [PATCH] avoid flash writes for new keys, with no values with fw_setenv Sridhar Addagada
2012-01-05 16:19 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120105161912.EFB2F1FD3DA@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox