[U-Boot] [PATCH 09/10] Correctly handle input files beginning with several newlines

[U-Boot] [PATCH 09/10] Correctly handle input files beginning with several newlines

[David Wagner]

Also, fix some comments (minor)

Signed-off-by: David Wagner <david.wagner@free-electrons.com>
---
 tools/mkenvimage.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/tools/mkenvimage.c b/tools/mkenvimage.c
index 9899631..0c9194b 100644
--- a/tools/mkenvimage.c
+++ b/tools/mkenvimage.c
@@ -224,18 +224,18 @@ int main(int argc, char **argv)
 	/* Replace newlines separating variables with \0 */
 	for (fp = 0, ep = 0 ; fp < filesize ; fp++) {
 		if (filebuf[fp] == '\n') {
-			if (fp == 0) {
+			if (ep == 0) {
 				/*
-				 * Newline at the beginning of the file ?
-				 * Ignore it.
+				 * Newlines@the beginning of the file ?
+				 * Ignore them.
 				 */
 				continue;
 			} else if (filebuf[fp-1] == '\\') {
 				/*
 				 * Embedded newline in a variable.
 				 *
-				 * The backslash was added to the envptr ;
-				 * rewind and replace it with a newline
+				 * The backslash was added to the envptr; rewind
+				 * and replace it with a newline
 				 */
 				ep--;
 				envptr[ep++] = '\n';
-- 
1.7.5.4

[U-Boot] [PATCH 09/10] Correctly handle input files beginning with several newlines

[Wolfgang Denk]

Dear David Wagner,

In message <1324429169-10177-1-git-send-email-david.wagner@free-electrons.com> you wrote:
> Also, fix some comments (minor)
> 
> Signed-off-by: David Wagner <david.wagner@free-electrons.com>
> ---
>  tools/mkenvimage.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Sorry, but my karma just ran over your dogma.