From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for MMC to fw_printenv/setenv
Date: Thu, 5 Jan 2012 18:28:57 -0500 [thread overview]
Message-ID: <201201051828.58176.vapier@gentoo.org> (raw)
In-Reply-To: <CAGFynZ9Vz1FJynUYZPEcMBN8Dk1P5o_sNHpfVry17Yntfg4j2g@mail.gmail.com>
On Monday 02 January 2012 18:49:11 Christian Daudt wrote:
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
>
> +static int fd_is_mtd(int fd)
> ...
> + rc = ioctl (fd, MEMGETINFO, &mtdinfo);
no space before the "("
> + if (rc < 0) {
> + // Failed MEMGETINFO, not MTD
> + return 0;
> + } else {
> + // Succeeded, MTD
> + return 1;
> + }
do not use // comments
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120105/5b0ed0ae/attachment.pgp>
prev parent reply other threads:[~2012-01-05 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGFynZ8d8N3F4jR4d=B+sMjGFO6ficaYQUzC2D34LYipNEbhMQ@mail.gmail.com>
2012-01-02 23:49 ` [U-Boot] [PATCH] Add support for MMC to fw_printenv/setenv Christian Daudt
2012-01-05 23:28 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201051828.58176.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox