From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Date: Thu, 5 Jan 2012 18:28:57 -0500
Subject: [U-Boot] [PATCH] Add support for MMC to fw_printenv/setenv
In-Reply-To: <CAGFynZ9Vz1FJynUYZPEcMBN8Dk1P5o_sNHpfVry17Yntfg4j2g@mail.gmail.com>
References: <CAGFynZ8d8N3F4jR4d=B+sMjGFO6ficaYQUzC2D34LYipNEbhMQ@mail.gmail.com>
	<CAGFynZ9Vz1FJynUYZPEcMBN8Dk1P5o_sNHpfVry17Yntfg4j2g@mail.gmail.com>
Message-ID: <201201051828.58176.vapier@gentoo.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday 02 January 2012 18:49:11 Christian Daudt wrote:
> --- a/tools/env/fw_env.c
> +++ b/tools/env/fw_env.c
> 
> +static int fd_is_mtd(int fd)
> ...
> +	rc = ioctl (fd, MEMGETINFO, &mtdinfo);

no space before the "("

> +	if (rc < 0) {
> +		// Failed MEMGETINFO, not MTD
> +		return 0;
> +	} else {
> +		// Succeeded, MTD
> +		return 1;
> +	}

do not use // comments
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120105/5b0ed0ae/attachment.pgp>