From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 8 Jan 2012 03:26:55 -0500 Subject: [U-Boot] [RFC PATCH v2 01/15] bootstage: Create an initial header for boot progress integers In-Reply-To: <1323551287-5351-2-git-send-email-sjg@chromium.org> References: <1323551287-5351-1-git-send-email-sjg@chromium.org> <1323551287-5351-2-git-send-email-sjg@chromium.org> Message-ID: <201201080326.56663.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Saturday 10 December 2011 16:07:53 Simon Glass wrote: > --- /dev/null > +++ b/include/bootstage.h > > +/* > + * This file implements recording of each stage of the boot process. It is > + * intended to implement timing of each stage, reporting this information > + * to the user and passing it to the OS for logging / further analysis. > + */ maybe it's me, but i'd expect this at the top of the file before the copyright/license notice > > + * progres action1 typo ? shows up a few times ... > +enum bootstage_id { > + BOOTSTAGE_ID_RUN_OS = 15, /* Exiting U-Boot, entering OS */ > +}; what relevance does this # have ? since it gets passed to Linux, it becomes part of the ABI and cannot be changed, so that should be mentioned in the comment. > +/* > + * Board-specific platform code can implement show_boot_progress () if "board-specific platform" is kind of redundant also, no space before "()" > --- a/include/common.h > +++ b/include/common.h > @@ -801,10 +801,8 @@ int pcmcia_init (void); > #ifdef CONFIG_STATUS_LED > # include > #endif > -/* > - * Board-specific Platform code can reimplement show_boot_progress () if > needed - */ > -void show_boot_progress(int val); > + > +#include > > /* Multicore arch functions */ > #ifdef CONFIG_MP -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: