[U-Boot] [RFC PATCH v2 04/15] bootstage: Convert progress numbers 1-9 into enums

Simon Glass
2012-01-08T17:27:54Z

Hi Mike,

On Sun, Jan 8, 2012 at 12:27 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Saturday 10 December 2011 16:07:56 Simon Glass wrote:
>> --- a/include/bootstage.h
>> +++ b/include/bootstage.h
>>
>> ?enum bootstage_id {
>> + ? ? BOOTSTAGE_ID_START,
>> + ? ? BOOTSTAGE_ID_CHECK_MAGIC, ? ? ? /* Checking image magic */
>> + ? ? BOOTSTAGE_ID_CHECK_HEADER, ? ? ?/* Checking image header */
>> + ? ? BOOTSTAGE_ID_CHECK_CHECKSUM, ? ?/* Checking image checksum */
>> + ? ? BOOTSTAGE_ID_CHECK_ARCH, ? ? ? ?/* Checking architecture */
>
> i know it's unlikely to ever change, but this would be good to be explicit:
> ? ? ? ?BOOTSTAGE_ID_START = 0,
> -mike

done

Regards,
Simon