[U-Boot] [RFC PATCH v2 01/15] bootstage: Create an initial header for boot progress integers

Simon Glass
2012-01-08T23:43:31Z

Hi Mike,

On Sun, Jan 8, 2012 at 11:46 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Sunday 08 January 2012 12:22:54 Simon Glass wrote:
>> On Sun, Jan 8, 2012 at 12:26 AM, Mike Frysinger wrote:
>> > On Saturday 10 December 2011 16:07:53 Simon Glass wrote:
>> >> +enum bootstage_id {
>> >> + ? ? BOOTSTAGE_ID_RUN_OS ? ? = 15, ? /* Exiting U-Boot, entering OS */
>> >> +};
>> >
>> > what relevance does this # have ? ?since it gets passed to Linux, it
>> > becomes part of the ABI and cannot be changed, so that should be
>> > mentioned in the comment.
>>
>> The number is currently open-coded in U-Boot but this series turns all
>> these occurrences into a global enum.
>
> yes, but the enum's have a numeric value :)
>

Yes for now - see my other message. I would like to remove the numbers
eventually.

>> Actually I don't plan that the
>> number be passed to Linux, or at least that Linux can rely on it being
>> anything in particular.
>
> ok, as long as the end goal has the # not being part of the ABI, that's good

That's right.

Regards,
Simon

> -mike