[U-Boot] [RFC PATCH v2 15/15] bootstage: arm: Add bootstage calls in board and bootm

Mike Frysinger
2012-01-08T19:58:28Z

On Sunday 08 January 2012 12:43:09 Simon Glass wrote:
> On Sun, Jan 8, 2012 at 12:36 AM, Mike Frysinger wrote:
> > On Saturday 10 December 2011 16:08:07 Simon Glass wrote:
> >> --- a/arch/arm/lib/bootm.c
> >> +++ b/arch/arm/lib/bootm.c
> >>
> >> static void announce_and_cleanup(void)
> >> {
> >> printf("\nStarting kernel ...\n\n");
> >> + bootstage_mark_name(BOOTSTAGE_ID_BOOTM_HANDOFF, "start_kernel");
> >> +#ifdef CONFIG_BOOTSTAGE_REPORT
> >> + bootstage_report();
> >> +#endif
> >
> > shouldn't the header make bootstage_report() into a stub when
> > CONFIG_BOOTSTAGE_REPORT isn't defined ? then you won't need the ifdef
> > protection here.
>
> Well maybe. I am hoping for a link error if someone calls it without
> defining that CONFIG. Otherwise it could be very confusing for people
> that they can't get a report!

i'm not sure we need worry about that
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120108/66750e8b/attachment.pgp>