From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] sandbox: sort header files in os.c
Date: Sun, 8 Jan 2012 03:49:20 -0500 [thread overview]
Message-ID: <201201080349.21381.vapier@gentoo.org> (raw)
In-Reply-To: <1325822097-15227-6-git-send-email-sjg@chromium.org>
On Thursday 05 January 2012 22:54:53 Simon Glass wrote:
> --- a/arch/sandbox/cpu/os.c
> +++ b/arch/sandbox/cpu/os.c
>
> +#include <errno.h>
> #include <fcntl.h>
> +#include <linux/types.h>
> #include <stdlib.h>
> #include <termios.h>
> -#include <unistd.h>
> #include <time.h>
> -#include <errno.h>
> -#include <sys/types.h>
> -#include <sys/stat.h>
> +#include <unistd.h>
> #include <sys/mman.h>
> -#include <linux/types.h>
> +#include <sys/stat.h>
> +#include <sys/types.h>
the order should generally be:
- stuff in include/
- stuff in sys/
- stuff in linux/
- stuff in asm/
each sub-region can be sorted, but i don't think we should go against the
subdir rule
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120108/f2fef496/attachment.pgp>
next prev parent reply other threads:[~2012-01-08 8:49 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 3:54 [U-Boot] [PATCH 0/9] Fix a few warnings that bug me Simon Glass
2012-01-06 3:54 ` [U-Boot] [PATCH 1/9] usb: Fix strict-aliasing warning in host/ohci-hcd.c Simon Glass
2012-01-08 9:32 ` Mike Frysinger
2012-01-08 18:02 ` Simon Glass
2012-01-06 3:54 ` [U-Boot] [PATCH 2/9] Fix strict-aliasing warning in dlmalloc Simon Glass
2012-01-06 6:48 ` Wolfgang Denk
2012-01-06 20:39 ` Simon Glass
2012-01-06 23:37 ` Wolfgang Denk
2012-01-08 0:57 ` Simon Glass
2012-01-08 9:27 ` Mike Frysinger
2012-08-13 15:25 ` Andreas Bießmann
2012-09-04 21:25 ` Andreas Bießmann
2012-01-06 3:54 ` [U-Boot] [PATCH 3/9] mpc5xxx: Fix strict-aliasing warnings in usb_ohci.c Simon Glass
2012-01-06 3:54 ` [U-Boot] [PATCH 4/9] ppc4xx: " Simon Glass
2012-10-16 6:28 ` Marek Vasut
2012-10-16 13:35 ` Simon Glass
2012-01-06 3:54 ` [U-Boot] [PATCH 5/9] sandbox: sort header files in os.c Simon Glass
2012-01-08 8:49 ` Mike Frysinger [this message]
2012-01-09 22:17 ` Simon Glass
2012-01-06 3:54 ` [U-Boot] [PATCH 6/9] sandbox: Add required header to os.c Simon Glass
2012-01-08 8:49 ` Mike Frysinger
2012-01-09 22:18 ` Simon Glass
2012-01-06 3:54 ` [U-Boot] [PATCH 7/9] Remove CONFIG_SYS_EXTBDINFO from snapper9260.h Simon Glass
2012-02-22 11:07 ` Stefano Babic
2012-03-27 16:58 ` Anatolij Gustschin
2012-01-06 3:54 ` [U-Boot] [PATCH 8/9] m68k: Change memsz to a signed char to avoid warning Simon Glass
2012-01-08 9:29 ` Mike Frysinger
2012-02-22 12:01 ` Stefano Babic
2012-01-06 3:54 ` [U-Boot] [PATCH 9/9] ppc: Change memsz variable to signed char Simon Glass
2012-01-08 9:29 ` Mike Frysinger
2012-02-22 12:00 ` Stefano Babic
2012-01-06 6:20 ` [U-Boot] [PATCH 0/9] Fix a few warnings that bug me Wolfgang Denk
2012-01-06 6:28 ` Simon Glass
2012-02-20 18:49 ` Simon Glass
2012-02-21 10:20 ` Stefano Babic
2012-02-21 13:49 ` Stefano Babic
2012-02-21 17:06 ` Mike Frysinger
2012-02-21 17:15 ` Stefano Babic
2012-02-21 18:40 ` Simon Glass
2012-02-22 5:35 ` Mike Frysinger
2012-02-22 11:06 ` Stefano Babic
2012-03-03 14:31 ` Wolfgang Denk
2012-03-05 18:22 ` Marek Vasut
2012-03-05 18:33 ` Simon Glass
2012-03-05 18:42 ` Andy Pont
2012-03-05 19:17 ` Wolfgang Denk
2012-03-05 18:46 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201080349.21381.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox