From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 01/14] Add AES crypto library
Date: Sun, 8 Jan 2012 04:09:11 -0500 [thread overview]
Message-ID: <201201080409.12513.vapier@gentoo.org> (raw)
In-Reply-To: <201201080957.48063.marek.vasut@gmail.com>
On Sunday 08 January 2012 03:57:47 Marek Vasut wrote:
> > On Monday 26 December 2011 14:32:54 Simon Glass wrote:
> > > --- /dev/null
> > > +++ b/lib/aes.c
> > >
> > > +static u8 sbox[256] = {
> > > +static u8 inv_sbox[256] = {
> > > +static u8 x2_sbox[256] = {
> > > +static u8 x3_sbox[256] = {
> > > +static u8 x_time_9[256] = {
> > > +static u8 x_time_b[256] = {
> > > +static u8 x_time_d[256] = {
> > > +static u8 x_time_e[256] = {
> >
> > const
> >
> > > +static void mix_sub_columns(u8 *state)
> > > +{
> > > ...
> > > + x3_sbox[state[2]] ^ sbox[state[7]];
> >
> > looks bad whitespace after that ^
> >
> > > +static u8 rcon[11] = {
> >
> > const
>
> We already have checkpatch in tools ... run it on the series.
i don't think checkpatch catches const
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120108/3250cc48/attachment.pgp>
next prev parent reply other threads:[~2012-01-08 9:09 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 19:32 [U-Boot] [PATCH 0/14] tegra: warmboot (suspend / resume) support Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 01/14] Add AES crypto library Simon Glass
2012-01-08 5:49 ` Mike Frysinger
2012-01-08 8:57 ` Marek Vasut
2012-01-08 9:09 ` Mike Frysinger [this message]
2012-01-08 10:40 ` Marek Vasut
2012-01-08 16:35 ` Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 02/14] tegra: Move ap20.h header into arch location Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 03/14] tegra: Add crypto library for warmboot code Simon Glass
2012-01-08 5:51 ` Mike Frysinger
2012-01-08 16:42 ` Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 04/14] tegra: Add flow, gp_padctl, fuse, sdram headers Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 05/14] tegra: Add tegra_get_chip_type() to detect SKU Simon Glass
2012-01-09 23:24 ` Stephen Warren
2012-01-12 19:35 ` Simon Glass
2012-01-12 19:48 ` Stephen Warren
2012-01-13 21:06 ` Simon Glass
2011-12-26 19:32 ` [U-Boot] [PATCH 06/14] tegra: Add EMC support for optimal memory timings Simon Glass
2012-01-09 23:38 ` Stephen Warren
2012-01-12 20:43 ` Simon Glass
2012-01-13 17:47 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 07/14] tegra: Add PMU to manage power supplies Simon Glass
2012-01-10 17:56 ` Stephen Warren
2012-01-12 23:17 ` Simon Glass
2012-01-12 23:43 ` Stephen Warren
2012-01-12 23:55 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 08/14] tegra: Set up PMU for Nvidia boards Simon Glass
2012-01-10 18:02 ` Stephen Warren
2012-01-12 23:42 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 09/14] tegra: Add warmboot implementation Simon Glass
2012-01-10 18:30 ` Stephen Warren
2012-01-13 19:34 ` Simon Glass
2012-01-13 22:04 ` Yen Lin
2012-01-13 23:05 ` Simon Glass
2012-01-13 23:08 ` Stephen Warren
2012-01-14 0:04 ` Yen Lin
2011-12-26 19:33 ` [U-Boot] [PATCH 10/14] tegra: Setup PMC scratch info from ap20 setup Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 11/14] tegra: Set up warmboot code on Nvidia boards Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 12/14] tegra: Set vdd_core and vdd_cpu to high Simon Glass
2012-01-10 18:40 ` Stephen Warren
2012-01-13 17:55 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 13/14] tegra: Add EMC settings for Seaboard, Harmony Simon Glass
2012-01-10 18:46 ` Stephen Warren
2012-01-12 23:05 ` Simon Glass
2012-01-12 23:42 ` Stephen Warren
2012-01-12 23:54 ` Simon Glass
2012-01-13 0:01 ` Stephen Warren
2012-01-13 0:05 ` Simon Glass
2012-01-13 0:10 ` Stephen Warren
2012-01-13 0:18 ` Simon Glass
2011-12-26 19:33 ` [U-Boot] [PATCH 14/14] tegra: Enable LP0 on Seaboard Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201080409.12513.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox