From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Sun, 8 Jan 2012 14:46:44 -0500 Subject: [U-Boot] [RFC PATCH v2 01/15] bootstage: Create an initial header for boot progress integers In-Reply-To: References: <1323551287-5351-1-git-send-email-sjg@chromium.org> <201201080326.56663.vapier@gentoo.org> Message-ID: <201201081446.46427.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sunday 08 January 2012 12:22:54 Simon Glass wrote: > On Sun, Jan 8, 2012 at 12:26 AM, Mike Frysinger wrote: > > On Saturday 10 December 2011 16:07:53 Simon Glass wrote: > >> +enum bootstage_id { > >> + BOOTSTAGE_ID_RUN_OS = 15, /* Exiting U-Boot, entering OS */ > >> +}; > > > > what relevance does this # have ? since it gets passed to Linux, it > > becomes part of the ABI and cannot be changed, so that should be > > mentioned in the comment. > > The number is currently open-coded in U-Boot but this series turns all > these occurrences into a global enum. yes, but the enum's have a numeric value :) > Actually I don't plan that the > number be passed to Linux, or at least that Linux can rely on it being > anything in particular. ok, as long as the end goal has the # not being part of the ABI, that's good -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. URL: