From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH v2 13/15] bootstage: Add microsecond boot time measurement
Date: Mon, 9 Jan 2012 12:33:42 -0500 [thread overview]
Message-ID: <201201091233.43471.vapier@gentoo.org> (raw)
In-Reply-To: <CAPnjgZ3t5A0L+zEmyvyHbXGnJadmucnkxe24y2FBF_xvDh4atA@mail.gmail.com>
On Sunday 08 January 2012 12:42:02 Simon Glass wrote:
> On Sun, Jan 8, 2012 at 12:35 AM, Mike Frysinger wrote:
> > On Saturday 10 December 2011 16:08:05 Simon Glass wrote:
> >> --- a/include/bootstage.h
> >> +++ b/include/bootstage.h
> >>
> >> +static inline ulong bootstage_mark(enum bootstage_id id)
> >> {
> >> - show_boot_progress(-val);
> >> +#ifdef CONFIG_SHOW_BOOT_PROGRESS
> >> + show_boot_progress(id);
> >> +#endif
> >> + return 0;
> >> }
> >>
> >> +static inline ulong bootstage_error(enum bootstage_id id)
> >> +{
> >> +#ifdef CONFIG_SHOW_BOOT_PROGRESS
> >> + show_boot_progress(-id);
> >> +#endif
> >> + return 0;
> >> +}
> >
> > why isn't show_boot_progress() just a stub when CONFIG_SHOW_BOOT_PROGRESS
> > isn't defined ? then you don't have to protect the call sites.
>
> show_boot_progress() has been part of U-Boot for a while. Quite a lot
> of boards define this function with the expectation that they can turn
> CONFIG_SHOW_BOOT_PROGRESS on and off independently. So If I do what
> you suggest I will break that expectation.
>
> One fix would be to bracket all show_boot_progress() function
> implementations in the boards with CONFIG_SHOW_BOOT_PROGRESS, but I
> haven't done that.
it seemed like part of your clean up series was to merge show_boot_progress()
into your new bootstage framework. in which case, we have full control over
it now, and ifdef bracketing for it should go away ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120109/c8377936/attachment.pgp>
next prev parent reply other threads:[~2012-01-09 17:33 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 21:07 [U-Boot] [RFC PATCH v2 0/15] bootstage: record and publish boot progress timing Simon Glass
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 01/15] bootstage: Create an initial header for boot progress integers Simon Glass
2012-01-08 8:26 ` Mike Frysinger
2012-01-08 17:22 ` Simon Glass
2012-01-08 19:46 ` Mike Frysinger
2012-01-08 23:43 ` Simon Glass
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 02/15] bootstage: Make use of BOOTSTAGE_ID_RUN_OS in show_boot_progress() Simon Glass
2012-01-08 8:26 ` Mike Frysinger
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 03/15] bootstage: Use show_boot_error() for -ve progress numbers Simon Glass
2012-01-08 8:27 ` Mike Frysinger
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 04/15] bootstage: Convert progress numbers 1-9 into enums Simon Glass
2012-01-08 8:27 ` Mike Frysinger
2012-01-08 17:27 ` Simon Glass
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 05/15] bootstage: Convert progress numbers 10-19 to enums Simon Glass
2012-01-08 8:28 ` Mike Frysinger
2012-01-08 17:29 ` Simon Glass
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 06/15] bootstage: Convert progress numbers 20-41 " Simon Glass
2011-12-10 21:07 ` [U-Boot] [RFC PATCH v2 07/15] bootstage: Convert IDE progress numbers " Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 08/15] bootstage: Convert NAND " Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 09/15] bootstage: Convert net " Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 10/15] bootstage: Convert FIT " Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 11/15] bootstage: Define an optional microsecond timer Simon Glass
2012-01-08 8:30 ` Mike Frysinger
2012-01-08 17:33 ` Simon Glass
2012-01-08 19:57 ` Mike Frysinger
2012-01-08 23:49 ` Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 12/15] bootstage: Replace show_boot_progress/error() with bootstage_...() Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 13/15] bootstage: Add microsecond boot time measurement Simon Glass
2012-01-08 8:35 ` Mike Frysinger
2012-01-08 17:42 ` Simon Glass
2012-01-09 17:33 ` Mike Frysinger [this message]
2012-01-12 5:41 ` Simon Glass
2012-01-15 1:09 ` Mike Frysinger
2012-01-15 1:16 ` Simon Glass
2012-01-15 1:22 ` Mike Frysinger
2012-01-15 1:27 ` Simon Glass
2012-02-13 23:27 ` Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 14/15] bootstage: Plumb in bootstage calls for basic operations Simon Glass
2011-12-10 21:08 ` [U-Boot] [RFC PATCH v2 15/15] bootstage: arm: Add bootstage calls in board and bootm Simon Glass
2012-01-08 8:36 ` Mike Frysinger
2012-01-08 17:43 ` Simon Glass
2012-01-08 19:58 ` Mike Frysinger
2012-01-08 23:48 ` Simon Glass
2012-01-09 17:31 ` Mike Frysinger
2012-01-12 5:38 ` Simon Glass
2012-01-03 22:33 ` [U-Boot] [RFC PATCH v2 0/15] bootstage: record and publish boot progress timing Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201091233.43471.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox