From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] USB: fix USB keyboard polling parameter
Date: Mon, 9 Jan 2012 21:53:36 +0100 [thread overview]
Message-ID: <201201092153.36637.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAP_ceTy8XV+wZH4V2FkQCXw=gZrTDcCocgPrrcY_=3UbWDoxRQ@mail.gmail.com>
> On Mon, Jan 9, 2012 at 12:46, Marek Vasut <marek.vasut@gmail.com> wrote:
> >> When doing a "GET_REPORT" request on the keyboard control endpoint,
> >> the report ID should 0 (ie report ID not used) rather than 1
> >> as reports are not used in boot mode.
> >>
> >> Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> >> ---
> >> common/usb_kbd.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/common/usb_kbd.c b/common/usb_kbd.c
> >> index 75107c9..aaf7d6f 100644
> >> --- a/common/usb_kbd.c
> >> +++ b/common/usb_kbd.c
> >> @@ -320,7 +320,7 @@ static inline void usb_kbd_poll_for_event(struct
> >> usb_device *dev) struct usb_kbd_pdata *data = dev->privptr;
> >> iface = &dev->config.if_desc[0];
> >> usb_get_report(dev, iface->desc.bInterfaceNumber,
> >> - 1, 1, data->new, sizeof(data->new));
> >> + 1, 0, data->new, sizeof(data->new));
> >> if (memcmp(data->old, data->new, sizeof(data->new)))
> >> usb_kbd_irq_worker(dev);
> >> #endif
> >
> > Good, did you test this?
>
> Yes, on about a dozen different keyboards :
> most don't care, a couple used to be confused and are now working.
Awesome :-) I'll test this on mine and Ack it then.
btw. why do you even need this? Do you have some weird hardware ?
M
next prev parent reply other threads:[~2012-01-09 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 18:35 [U-Boot] [PATCH] USB: fix USB keyboard polling parameter Vincent Palatin
2012-01-09 20:46 ` Marek Vasut
2012-01-09 20:50 ` Vincent Palatin
2012-01-09 20:53 ` Marek Vasut [this message]
2012-01-15 19:49 ` Remy Bohmer
2012-02-26 23:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201092153.36637.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox