From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Tue, 10 Jan 2012 00:10:59 +0100
Subject: [U-Boot] [PATCH] mx28: fix clearing of IRQs in power init
In-Reply-To: <4F0B4C9E.5060306@itwatchdogs.com>
References: <4F0B4C9E.5060306@itwatchdogs.com>
Message-ID: <201201100010.59920.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> There are 2 locations in the power init code for the mx28 where IRQs are
> not being cleared because incorrect methods to clear those bits were being
> used.  This was causing my board to get stuck waiting for
> POWER_CTRL_VDD5V_DROOP_IRQ to clear.  Using the correct method to clear
> the IRQs fixes it.
> 
> Signed-off-by: Zach Sadecki <zach@itwatchdogs.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
>  arch/arm/cpu/arm926ejs/mx28/spl_power_init.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c index a4dc2a3..380b120
> 100644
> --- a/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> +++ b/arch/arm/cpu/arm926ejs/mx28/spl_power_init.c
> @@ -240,8 +240,8 @@ void mx28_enable_4p2_dcdc_input(int xfer)
>  		clrbits_le32(&power_regs->hw_power_minpwr, POWER_MINPWR_PWD_BO);
> 
>  	while (readl(&power_regs->hw_power_ctrl) & POWER_CTRL_VBUS_VALID_IRQ)
> -		clrbits_le32(&power_regs->hw_power_ctrl,
> -				POWER_CTRL_VBUS_VALID_IRQ);
> +		writel(POWER_CTRL_VBUS_VALID_IRQ,
> +			&power_regs->hw_power_ctrl_clr);
> 
>  	if (prev_5v_brnout) {
>  		writel(POWER_5VCTRL_PWDN_5VBRNOUT,
> @@ -256,8 +256,8 @@ void mx28_enable_4p2_dcdc_input(int xfer)
>  	}
> 
>  	while (readl(&power_regs->hw_power_ctrl) & POWER_CTRL_VDD5V_DROOP_IRQ)
> -		clrbits_le32(&power_regs->hw_power_ctrl,
> -				POWER_CTRL_VDD5V_DROOP_IRQ);
> +		writel(POWER_CTRL_VDD5V_DROOP_IRQ,
> +			&power_regs->hw_power_ctrl_clr);
> 
>  	if (prev_5v_droop)
>  		clrbits_le32(&power_regs->hw_power_ctrl,

Hello,

this is an impressive catch! I did investigation of the Freescale bootlets code 
and found out you're right, it's an SCT register. So:

Acked-by: Marek Vasut <marek.vasut@gmail.com>

M