From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sughosh Ganu <urwithsughosh@gmail.com>
Date: Tue, 10 Jan 2012 15:43:18 +0530
Subject: [U-Boot] [PATCH 2/2] Changes to move hawkboard to the new
 infrastructure.
In-Reply-To: <4F0C07F0.9090003@denx.de>
References: <1326133729-6760-1-git-send-email-urwithsughosh@gmail.com>
	<4F0B78B0.6070504@ti.com> <20120110063041.GB7838@Hardy>
	<CABkLObpJn33_bVsa+A3E_+0Q6ZXqUJ=7wHZ72tGCqAHENF-GNA@mail.gmail.com>
	<20120110084231.GC7838@Hardy> <4F0C07F0.9090003@denx.de>
Message-ID: <20120110101318.GA9123@Hardy>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

hi Heiko,
On Tue Jan 10, 2012 at 10:42:08AM +0100, Heiko Schocher wrote:
> Hello Sughosh, Christian, Tom,
> 
> Sughosh Ganu wrote:

> >>>  I see a CONFIG_MACH_DAVINCI_* like define in da850evm.h and
> >>>  hawkboard.h. Should i add a similar define for cam_enc_4xx, and use
> >>>  these instead.
> >> Actually the problem is that now we have a board specific file
> >> (hawkboard_nand_spl.c) in the arch tree. Hawkboard has a DA850 SoC so if we
> >> have a da850_spl.c hawkboard should either use it as well, or we make the
> >> *spl.c files board specific and put them into the board tree.
> > 
> >   I'd vote for moving the *spl.c files to their corresponding board
> >   directories -- infact hawkboard_nand_spl.c was earlier under it's
> >   board directory. This i think keeps the implementation clean, avoids
> >   the risk of breakage, and also makes it simpler for any newer board
> >   in the same soc family migrating to spl, which i think might
> >   increase the ifdeffery.
> 
> Hmm.. I vote against creating board specific files. I am here in line
> with Christians proposal, posted here:
> 
> http://lists.denx.de/pipermail/u-boot/2012-January/115166.html
> 
> Did this work for the hawkboard? If you do not need some inits, maybe
> we add here defines or better make this functions weak, and you can write
> board specific functions for this parts. The code in board_init_r()
> is only a "selection" from where to load u-boot, which I think in the
> long term could be made more common for other SoCs too ... so I want
> to prevent to split this in board specific files.

  I should be able to test these changes in the evening. Will send a
  modified patch after testing.

-sughosh