public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected
Date: Tue, 10 Jan 2012 12:46:01 +0100	[thread overview]
Message-ID: <201201101246.01173.marek.vasut@gmail.com> (raw)
In-Reply-To: <CAOMZO5CrpL1iNZafs-f24nM-k-yx+vDAaU5iGZ3_U-iDJN5TWA@mail.gmail.com>

> Hi Marek,
> 
> On Sun, Jan 1, 2012 at 2:28 AM, Marek Vasut <marek.vasut@gmail.com> wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Stefano Babic <sbabic@denx.de>
> > ---
> >  include/configs/m28evk.h |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> > 
> > diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> > index 39c841f..dcea878 100644
> > --- a/include/configs/m28evk.h
> > +++ b/include/configs/m28evk.h
> > @@ -140,6 +140,7 @@
> >  /*
> >  * NAND
> >  */
> > +#define        CONFIG_ENV_SIZE                 (16 * 1024)
> >  #ifdef CONFIG_CMD_NAND
> >  #define        CONFIG_NAND_MXS
> >  #define CONFIG_APBH_DMA
> > @@ -150,7 +151,6 @@
> > 
> >  /* Environment is in NAND */
> >  #define        CONFIG_ENV_IS_IN_NAND
> > -#define        CONFIG_ENV_SIZE                 (16 * 1024)
> >  #define        CONFIG_ENV_SIZE_REDUND          CONFIG_ENV_SIZE
> >  #define        CONFIG_ENV_SECT_SIZE            (128 * 1024)
> >  #define        CONFIG_ENV_RANGE                (512 * 1024)
> > @@ -173,6 +173,8 @@
> >                "512k(redundant-environment),"  \
> >                "4m(kernel),"                   \
> >                "-(filesystem)"
> > +#else
> > +#define        CONFIG_ENV_IS_NOWHERE
> 
> Couldn't you use CONFIG_ENV_IS_IN_MMC instead of CONFIG_ENV_IS_NOWHERE
> here?

We decided to not have env elsewhere until env-in-multiple-locations patch is in 
place.

M
> 
> Regards,
> 
> Fabio Estevam

  reply	other threads:[~2012-01-10 11:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-01  4:28 [U-Boot] [PATCH] M28EVK: Fix build if CONFIG_CMD_NAND not selected Marek Vasut
2012-01-10 11:05 ` Marek Vasut
2012-01-10 11:08 ` Fabio Estevam
2012-01-10 11:46   ` Marek Vasut [this message]
2012-01-11  8:02 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201101246.01173.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox