From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] NAND: Allow nand_ids and nand_bbt to be compiled in SPL
Date: Tue, 10 Jan 2012 13:25:56 -0500 [thread overview]
Message-ID: <201201101325.57593.vapier@gentoo.org> (raw)
In-Reply-To: <CA+M6bXkY1bhS1WUuDzbU=EDvWjx3y58HvbDwA2PcO_o6gSc=_A@mail.gmail.com>
On Monday 09 January 2012 16:25:41 Tom Rini wrote:
> On Mon, Jan 9, 2012 at 2:23 PM, Tom Rini <tom.rini@gmail.com> wrote:
> > On Mon, Jan 9, 2012 at 2:21 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> >> On Monday 09 January 2012 14:41:07 Scott Wood wrote:
> >>> Unless/until the toolchain can properly GC anonymous strings, I think
> >>> finer-grained conditional compilation is the way to go.
> >>
> >> i think we should use GC when it works (we've found 1 case so far where
> >> it doesn't), and add fine grained compilation when it doesn't (with a
> >> note with expected working versions). i think this is a bug in the
> >> linker and have been trying to make a reduced test case that i can post
> >> to the GNU binutils peeps.
> >
> > We've found two cases, at least. Functions aren't being dropped out
> > either.
>
> To be clear,
> https://github.com/trini/u-boot/commit/3a7c313125eff000ac73e38d220e5f9615c
> 1abbe shows switching everything to the normal nand codebase, but with a
> gain of only 170 bytes. The reason it's such an otherwise small delta is
> that I added some #ifndef CONFIG_SPL_BUILD to drop out unused code that
> the linker should have been dropping for us, but wasn't.
how exactly do i reproduce the issue ? what do i `make xxx` ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120110/2cf92a12/attachment.pgp>
next prev parent reply other threads:[~2012-01-10 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 23:17 [U-Boot] [PATCH] NAND: Allow nand_ids and nand_bbt to be compiled in SPL Marek Vasut
2012-01-04 23:56 ` Scott Wood
2012-01-05 3:11 ` Tom Rini
2012-01-05 9:09 ` Marek Vasut
2012-01-05 14:15 ` Tom Rini
2012-01-05 23:04 ` Scott Wood
2012-01-06 0:41 ` Tom Rini
2012-01-06 19:03 ` Scott Wood
2012-01-06 19:14 ` Tom Rini
2012-01-06 19:18 ` Scott Wood
2012-01-08 9:56 ` Mike Frysinger
2012-01-09 19:41 ` Scott Wood
2012-01-09 21:21 ` Mike Frysinger
2012-01-09 21:23 ` Tom Rini
2012-01-09 21:25 ` Tom Rini
2012-01-10 18:25 ` Mike Frysinger [this message]
2012-01-10 18:36 ` Tom Rini
2012-01-09 21:27 ` Scott Wood
2012-01-10 18:25 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201101325.57593.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox