From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sughosh Ganu Date: Wed, 11 Jan 2012 20:39:53 +0530 Subject: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it. In-Reply-To: <201201111601.31484.marek.vasut@gmail.com> References: <1326133550-6706-1-git-send-email-urwithsughosh@gmail.com> <201201111452.44551.marek.vasut@gmail.com> <20120111144625.GA4301@Hardy> <201201111601.31484.marek.vasut@gmail.com> Message-ID: <20120111150952.GB4301@Hardy> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: > > More so, given the fact that we don't have any control over > > rbl -- so if rbl changes it's layout for any subsequent board, we'd > > have to add that as well to the nand driver, and both in u-boot as > > well as the kernel. > > > > I guess the cleanest solution would have been for the rbl to have > > used the same layout as the one used by u-boot and linux. > > Yep, why not do that then? Because rbl is a proprietary bootloader from TI. > > > > Btw, can you please review this change, that this patch > > fixes. ACK/NAK? > > I'll think about it. It's ok, but it piles one workaround on top of another one, > I don't like that approach. Flushing the data cache before disabling it is not a workaround, it's a fix. The current code is invalidating the cache instead of flushing it. -sughosh