public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/4] zipitz2: fix boot issue introduced by PXA low level init rework
Date: Wed, 11 Jan 2012 23:09:46 +0100	[thread overview]
Message-ID: <201201112309.46806.marek.vasut@gmail.com> (raw)
In-Reply-To: <1326319289-7065-4-git-send-email-anarsoul@gmail.com>

> CONFIG_SYS_INIT_SP_ADDR points to RAM, but it's used before
> DRAM controller init. Fix it by setting CONFIG_SYS_INIT_SP_ADDR
> to SRAM
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> v2: no changes
> 
>  include/configs/zipitz2.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/zipitz2.h b/include/configs/zipitz2.h
> index 1b14cc7..e7895ab 100644
> --- a/include/configs/zipitz2.h
> +++ b/include/configs/zipitz2.h
> @@ -184,7 +184,7 @@ unsigned char zipitz2_spi_read(void);
>  #define	CONFIG_SYS_LOAD_ADDR		CONFIG_SYS_DRAM_BASE
> 
>  #define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
> -#define	CONFIG_SYS_INIT_SP_ADDR		(GENERATED_GBL_DATA_SIZE + 
PHYS_SDRAM_1 +
> 2048) +#define	CONFIG_SYS_INIT_SP_ADDR		0x5c038000

Why do you keep setting the arbitrary location here? Just use 
GENERATED_GBL_DATA_SIZE + PHYS_SRAM + 2048) or something. ... define PHYS_SRAM 
if needed.

M
> 
>  /*
>   * NOR FLASH

  reply	other threads:[~2012-01-11 22:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 22:01 [U-Boot] [PATCH v2 1/4] PXA: PXA27x Matrix keypad driver Vasily Khoruzhick
2012-01-11 22:01 ` [U-Boot] [PATCH v2 2/4] zipitz2: enable pxa27x_mkp driver Vasily Khoruzhick
2012-01-11 22:12   ` Marek Vasut
2012-01-11 22:01 ` [U-Boot] [PATCH v2 3/4] zipitz2: use pxa_mmc_gen as MMC driver Vasily Khoruzhick
2012-01-11 22:12   ` Marek Vasut
2012-01-11 22:01 ` [U-Boot] [PATCH v2 4/4] zipitz2: fix boot issue introduced by PXA low level init rework Vasily Khoruzhick
2012-01-11 22:09   ` Marek Vasut [this message]
2012-01-11 22:11 ` [U-Boot] [PATCH v2 1/4] PXA: PXA27x Matrix keypad driver Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201112309.46806.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox