From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 12 Jan 2012 08:02:42 +0100 Subject: [U-Boot] [PATCH] nand_spl: store ecc data on the stack In-Reply-To: <20120111223434.GA12017@schlenkerla.am.freescale.net> References: <20120111223434.GA12017@schlenkerla.am.freescale.net> Message-ID: <201201120802.42279.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday 11 January 2012 23:34:35 Scott Wood wrote: > Adapt the following patch from spl to nand_spl: > > Author: Stefano Babic > Date: Thu Dec 15 10:55:37 2011 +0100 > > nand_spl_simple: store ecc data on the stack > > Currently nand_spl_simple puts it's temp data at 0x10000 offset in > SDRAM which is likely to contain already loaded data. > The patch saves the oob data and the ecc on the stack replacing > the fixed address in RAM. > > Signed-off-by: Stefano Babic > CC: Ilya Yanok > CC: Scott Wood > CC: Tom Rini > CC: Simon Schwarz > CC: Wolfgang Denk > Signed-off-by: Scott Wood > > While nand_spl is on its way out, in favor of spl, there are still > many boards using it, and conversions are gradual. This allows us > to get rid of CONFIG_SYS_NAND_ECCSTEPS and CONFIG_SYS_NAND_ECCTOTAL now, > which would otherwise be likely to linger unreferenced after a conversion. > > It also eliminates a temporary error in the hawkboard_nand build, since > the spl version of the patch removed ECCSTEPS/TOTAL from hawkboard.h, but > the spl conversion is pending (and may be merged via a different tree). Thanks Scott. Tested on kilauea_nand, so: Tested-by: Stefan Roese Best regards, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de >From urwithsughosh at Hardy Thu Jan 12 07:23:12 2012 From: urwithsughosh at Hardy (Sughosh Ganu) Date: Thu, 12 Jan 2012 11:53:12 +0530 Subject: [U-Boot] [PATCH 1/2 V2] arm926: Flush the data cache before disabling it. In-Reply-To: <201201111950.50699.marek.vasut@gmail.com> References: <1326133550-6706-1-git-send-email-urwithsughosh@gmail.com> <201201111601.31484.marek.vasut@gmail.com> <20120111150952.GB4301@Hardy> <201201111950.50699.marek.vasut@gmail.com> Message-ID: <20120112062312.GA5879@Hardy> On Wed Jan 11, 2012 at 07:50:50PM +0100, Marek Vasut wrote: > > On Wed Jan 11, 2012 at 04:01:31PM +0100, Marek Vasut wrote: > > > > More so, given the fact that we don't have any control over > > > > rbl -- so if rbl changes it's layout for any subsequent board, we'd > > > > have to add that as well to the nand driver, and both in u-boot as > > > > well as the kernel. > > > > > > > > I guess the cleanest solution would have been for the rbl to have > > > > used the same layout as the one used by u-boot and linux. > > > > > > Yep, why not do that then? > > > > Because rbl is a proprietary bootloader from TI. > > Don't we actually have replacement bootloader in uboot already ? You don't need > xloader with uboot anymore I think. No, this rbl resides in the rom area on the SOC and cannot be done away with. > > > > > > Btw, can you please review this change, that this patch > > > > fixes. ACK/NAK? > > > > > > I'll think about it. It's ok, but it piles one workaround on top of > > > another one, I don't like that approach. > > > > Flushing the data cache before disabling it is not a workaround, > > it's a fix. The current code is invalidating the cache instead of > > flushing it. > > Ok, but I'd like to see proper solution eventually. I think patch holds true irrespective of whether we rbl boots spl, or u-boot. -sughosh