From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut@gmail.com>
Date: Fri, 13 Jan 2012 13:17:58 +0100
Subject: [U-Boot] [PATCH 1/2] SPI: Add i.MX ECSPI driver
In-Reply-To: <4F0FDE09.2010108@de.bosch.com>
References: <1326382034-31058-1-git-send-email-dirk.behme@de.bosch.com>
	<201201121637.20848.marek.vasut@gmail.com>
	<4F0FDE09.2010108@de.bosch.com>
Message-ID: <201201131317.58392.marek.vasut@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> On 12.01.2012 16:37, Marek Vasut wrote:
> >> From: Eric Nelson <eric.nelson@boundarydevices.com>
> >> 
> >> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> >> CC: Jason Liu <jason.hui@linaro.org>
> >> CC: Stefano Babic <sbabic@denx.de>
> >> ---
> 
> ...
> 
> >> +     if (max_hz < imx_spi_slave->freq)
> >> +             imx_spi_slave->freq = max_hz ;
> > 
> > " ;" <-- fix globally ... run tools/checkpatch.pl before submitting
> 
> First, many thanks for the review!
> 
> Just one question: Which checkpatch do you use for this?
> 
> I ran checkpatch from Linux 3.2 before submitting and got [1] (which I
> think is ok). Using U-Boot's checkpatch I get [2].
> 
> Many thanks again and bet regards

Ok then, it's probably another issue checpatch doesn't catch.

M
> 
> Dirk
> 
> [1]
> 
> linux-2.6.git/scripts/checkpatch.pl 0001-SPI-Add-i.MX-ECSPI-driver.patch
> 
> WARNING: Use #include <linux/errno.h> instead of <asm/errno.h>
> #60: FILE: drivers/spi/imx_ecspi.c:26:
> +#include <asm/errno.h>
> 
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>
> #62: FILE: drivers/spi/imx_ecspi.c:28:
> +#include <asm/io.h>
> 
> total: 0 errors, 2 warnings, 438 lines checked
> 
> 0001-SPI-Add-i.MX-ECSPI-driver.patch has style problems, please review.
>   If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 
> 
> [2]
> 
> u-boot/tools/checkpatch.pl 0001-SPI-Add-i.MX-ECSPI-driver.patch
> 
> total: 0 errors, 0 warnings, 438 lines checked
> 
> NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX
> MULTISTATEMENT_MACRO_USE_DO_WHILE
> 
> 0001-SPI-Add-i.MX-ECSPI-driver.patch has no obvious style problems and
> is ready for submission.