public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v2] powerpc/85xx: move the Fman microcode from ef000000 to eff40000
Date: Fri, 13 Jan 2012 19:42:43 +0100	[thread overview]
Message-ID: <20120113184243.CBABC11CDEDB@gemini.denx.de> (raw)
In-Reply-To: <1326472903-6423-1-git-send-email-timur@freescale.com>

Dear Timur Tabi,

In message <1326472903-6423-1-git-send-email-timur@freescale.com> you wrote:
> On some Freescale reference boards for SOCs with Fman devices, the Fman
> microcode is located at address 0xEF000000 in NOR flash.  Unfortunately,
> this address is in the "middle of nowhere" and makes it difficult to
> partition flash space for other images.
> 
> So we change the expected address to 0xEFF40000, which is the flash
> sector adjacent to the environment.

Instead  of hard-coding magic addresses which then need to be changed
again and again, would it not make more sense to read the value from
an environment variable so it can be easily changed without having to
modify the source, rebuild, reinstall all the time?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A dog always bit deepest on the veterinary hand.
                                    - Terry Pratchett, _Wyrd Sisters_

  reply	other threads:[~2012-01-13 18:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 16:41 [U-Boot] [PATCH] [v2] powerpc/85xx: move the Fman microcode from ef000000 to eff40000 Timur Tabi
2012-01-13 18:42 ` Wolfgang Denk [this message]
2012-01-13 18:50   ` Timur Tabi
2012-01-13 20:46     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120113184243.CBABC11CDEDB@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox