public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back
Date: Fri, 13 Jan 2012 20:19:08 +0100	[thread overview]
Message-ID: <20120113191908.3C36511CDEDB@gemini.denx.de> (raw)
In-Reply-To: <1313559224-4627-1-git-send-email-eric.miao@linaro.org>

Dear Eric Miao,

In message <1313559224-4627-1-git-send-email-eric.miao@linaro.org> you wrote:
> Ignore the return value of eth_getenv_enetaddr_by_index(), and if it
> fails, fall back to use dev->enetaddr, which could be filled up by
> the ethernet device driver.
> 
> Actually, this is the original behavior, and was later changed by
> commit 48506a2cde2458fa1f8c5993afc98e5a4617e1d3.

I'm not going to pull that patch.

Please explain which actual problem you're trying to fix.

Also, fix the commit ID - the one you list above does not exist in
mainline.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A direct quote from the Boss: "We passed over a lot of good people to
get the ones we hired."

  parent reply	other threads:[~2012-01-13 19:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-17  5:33 [U-Boot] [PATCH] net/eth.c: fix eth_write_hwaddr() to use dev->enetaddr as fall back Eric Miao
2011-08-17  6:22 ` Simon Glass
2012-01-11 12:23   ` Dirk Behme
2012-01-12  5:12     ` Simon Glass
2012-01-12  7:48       ` Stefan Roese
2012-01-12  7:55 ` Stefan Roese
2012-01-13 19:19 ` Wolfgang Denk [this message]
2012-01-16  7:03   ` Eric Miao
2012-01-16  7:08     ` Eric Miao
2012-01-16 14:08   ` Philip Balister
2012-01-16 16:00     ` Wolfgang Denk
  -- strict thread matches above, loose matches on Subject: below --
2012-01-16 21:55 Zach Sadecki
2012-01-17  9:52 ` Wolfgang Denk
2012-01-17 16:17   ` Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120113191908.3C36511CDEDB@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox