From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Fri, 13 Jan 2012 22:25:32 +0100 Subject: [U-Boot] [PATCH v2 4/9] Stop using builtin_run_command() In-Reply-To: References: <1323542641-14541-1-git-send-email-sjg@chromium.org> <1323542641-14541-5-git-send-email-sjg@chromium.org> <20120113192716.210E711CDEDB@gemini.denx.de> Message-ID: <20120113212532.9399711CDEDB@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Simon Glass, In message you wrote: > > > run_command2() in "common/main.c" (now renamed into run_command() will > > return 0 or 1 when used with the hush shell; it will never return < 0. > > Thanks for looking at this. I will see what I can figure out. I think there is some pre-existing inconsistency here, which pops up when you try to unify the code. I think we should implement standard shell handline here: commands return EXIT_SUCCESS or EXIT_FAILURE. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The most exciting phrase to hear in science, the one that heralds new discoveries, is not "Eureka!" (I found it!) but "That's funny ..." -- Isaac Asimov